Repository navigation
Benchmarks: run parallel mode with a Julia thread per worker - #942
Merged
Merged
Conversation
Every benchmark process ran with one Julia thread, and only PoCL's worker count followed the mode. A backend that runs work-groups on Julia's threads, as in #906, then ran the parallel benchmarks on one thread, against main's 8 PoCL workers on the benchmark machine. Give each process as many Julia threads as it has workers (and no interactive thread); serial and latency processes keep one. [only benchmarks]
Contributor
Benchmark resultsCompared with 14002d752, the merge base.
No unusual changes. All benchmarks
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
==========================================
- Coverage 83.17% 82.46% -0.72%
==========================================
Files 31 31
Lines 2567 2520 -47
==========================================
- Hits 2135 2078 -57
- Misses 432 442 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark harness runs every process with one Julia thread, and only sets PoCL's worker count per mode. A backend that runs work-groups on Julia's threads therefore runs the parallel benchmarks on one thread. That is why #906's benchmark comment shows 3–8× slowdowns: the CI machine has 8 cores, and main used 8 PoCL workers.
This gives each process as many Julia threads as it has workers, with no interactive thread (
JULIA_NUM_THREADS="$threads,0"). Serial and latency processes still get one thread, as before.Minimum times on a 9950X (8 cores via
taskset,JULIA_KA_CPU_THREADS=8):-t1-t8,0-t1-t8,0Main also changes with the extra threads (groupscan and across-barrier get faster), so this should merge before #906 is compared again.