Repository navigation
Port isbits support to CPU backend - #943
christiangnrd wants to merge 2 commits into
Conversation
Port of JuliaGPU/OpenCL.jl#583: elements are strided by `Base.aligned_sizeof`, and only isbits unions keep their selector bytes past the data (a struct with a union field carries its selector inline). Arrays passed to kernels locate their selector bytes from the `Array`'s memory, which can be longer than the array or start before it. Requires SPIRVIntrinsics 1.5.1, which sizes local memory of unions correctly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Benchmark resultsCompared with 7d2ea0f46, the merge base. Times are the minimum time of every benchmark. A change is unusual when it exceeds both three times the benchmark's typical change between consecutive runs on the default branch and a minimum per category (performance 3%, latency 5%, applications 3%, other 3%). A benchmark that starts or stops allocating is listed however few the allocations. A single run can still be a fluke, so rerun before drawing conclusions.
No unusual changes. All benchmarks
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
+ Coverage 83.17% 83.85% +0.68%
==========================================
Files 31 31
Lines 2567 2533 -34
==========================================
- Hits 2135 2124 -11
+ Misses 432 409 -23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Does this need tests or are the GPUArrays tests (that don't run here) sufficient?