Repository navigation
Use IndexedDB in a Web Worker: detect the browser on indexedDB, not window - #178
Merged
Merged
Conversation
…indow LevelStorage chose between the browser and Node.js on `typeof window`. A Web Worker has no `window`, so the client took the Node.js path there and called `os.tmpdir()` or `fs.existsSync()`, which are empty modules in the browser build: every replication in a worker failed. Decide on `typeof indexedDB` instead, and add a browser test that replicates in a Worker with and without a statePath. Fixes #177 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LevelStorage chose between the browser and Node.js on
typeof window. A Web Worker has nowindow, so the client took the Node.js path there and calledos.tmpdir()orfs.existsSync(), which are empty modules in the browser build: every replication in a worker failed. Decide ontypeof indexedDBinstead, and add a browser test that replicates in a Worker with and without a statePath.Fixes #177