LightController sleeping vs KAL

[flushstar]

When a ModuleLight is kept continuously on and strobing is simulated by changing the light color through the RGB channels by KAL-1000, Waterfall's light controller does not detect the color changes. As a result, the effect goes to sleep and the light cone does not follow the strobe. Setting ForceAllControllersAwake = true is the only way to make it work correctly.

This matches the comment in WaterfallSettings.cfg: if something does not work when it is false (the default) but works when it is true, it is a bug in Waterfall.

[JonnyOThan]

@flushstar Can you post a craft file (and your waterfall configs) that demonstrates the issue? It would save us a lot of time. The LightController only fetches the light intensity, not the color. So I'm not sure why controller sleeping would be relevant here without seeing what you're actually doing.

Hypothesis: if all controllers on the effect go to sleep, none of the modifiers will run which is what ultimately fetches the color of the ModuleLight into the waterfall effect material.

Forcing controllers awake is a really bad solution, because the vast majority of controllers and effects on a typical ship ARE sleeping (deactivated RCS/engines, for example). Even light effects don't change often (at least in vacuum).

There may be a way to keep the LightController awake when the color properties on the ModuleLight are changing (at the very least by binding delegates to their property changed handlers) which may handle the majority of these issues.

[flushstar]

@JonnyOThan

https://drive.google.com/file/d/1Epy3G51d7koqXD2xSMr7FZtU_CEbYXIp/view?usp=sharing
Sorry I just forgot this issue...
Here are my Waterfall plugins an craft.