Conversation
| // Parse attachment nodes | ||
| if (!string.IsNullOrWhiteSpace(requiredNodes)) | ||
| { | ||
| foreach (string nodeName in requiredNodes.Split(',')) |
There was a problem hiding this comment.
How about allowing the requiredNodes key to be specified more than once, rather than splitting by commas? That tends to work better with MM patches.
There was a problem hiding this comment.
That does sound a bit more standard.
The commas are a leftover from the previous module version which clustered every node group into one. The commas were used like seperators in parallel lists to have them paired up.
There was a problem hiding this comment.
The transform list is liable to become quite long and other mods take the comma approach(well, semicolon, but I'd changed the split identifier just now)
Working from patches its'a already very flexible
| CacheInitialChildren(); | ||
| ParseConfig(); | ||
| UpdateVisuals(); | ||
| } |
There was a problem hiding this comment.
If this module doesn't need to do anything in Update, it might be wise to disable it: https://github.com/KSP-KOS/KOS/blob/8f281a459b6ea0ba917c91bbbc117e68bb948199/src/kOS/Module/KOSNameTag.cs#L66
There was a problem hiding this comment.
True. It's only driven by editor events
Module is event driven and doesn't run inflight. disabled the frame behaviour
2 participants
Uh oh!
There was an error while loading. Please reload this page.