Panel search and black bars for rebuilt PDFs - #32
Open
FWao wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search inside a result panel
Each text panel gets a search in its header;
Ctrl/Cmd+Fopens it in the panel the reviewer last worked in. Hits are marked and counted, case- and diacritic-insensitive (mullerfinds Müller). A selected find offers Im Ergebnis suchen — the one-click final check that a name really is gone from the output.PDF views have no search of their own: a browser PDF viewer cannot be searched or highlighted from the app, so the shortcut skips them for the nearest text panel, and Im Ergebnis suchen switches a PDF result panel to the anonymized text, where the hit can actually be shown.
Black bars in a rebuilt PDF
A native PDF blacks its redactions out, while a scanned document's reconstruction printed them as words (
[PERSON_1]). Schwarze Balken statt Platzhaltern in the export menu (scanned sources only) draws a bar over each placeholder so both look alike. The placeholder stays in the text layer, so copy-paste still yields the tag, and generalized dates stay readable as in the native export. Toggling re-exports the previews of every scanned document of the batch, since the ZIP bundles them.Also
Fixes an argument-order bug in
downloadRedactedPdf:outputLanguagewas passed in theocrProfileslot, so a cache-miss PDF download sent a language as an OCR profile and no output language.