Let the reviewer confirm a PDF export refused by a residual the text output has too - #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PDF exporter applies redactions by offset but verifies by global text search, so a redacted string sitting at a non-redacted offset killed the export — a kept physician's name matching the patient's, or a redacted phrase recurring where no detector flagged it. The text export already ships in that case (HIGH
residual_identifier, statusFAIL); only the PDF refused.Residuals are now classified against the anonymized text output:
forceable: true, naming the passages → Trotzdem exportierenforce_exportignoredNative PDFs black out every occurrence, so this fires on the scanned rebuild.
The confirmation is per finding, not a mode: after an override re-run the export goes out unforced first and the earlier confirmation is re-applied only if it covers everything the new refusal names. The PDF panel keeps an amber notice while a forced export is on screen. Refusal body is now
{detail, code, forceable, items, count},detailunchanged.Tests: 5 unit, 2 integration, 3 Vitest. Full gate green (ruff, pytest 391,
npm run check, vitest, build, e2e 15). Docs: new When the check finds text you kept indocs/user-guide/export.md, plusdocs/index.md,RISK_REGISTER.mdS4 andAGENTS.md.