Repository navigation
fix(security): Hide exception text and bound HTML strip regex - #21
Merged
Merged
Conversation
CodeQL py/stack-trace-exposure: order sync, flow execution and directory batch registration returned str(exception) to API clients. Return fixed messages instead; details stay in server logs (logger.exception) and integration_logs. CodeQL py/polynomial-redos: _strip_html used <[^>]+>, which is O(n^2) on input like "<<<<...". Excluding '<' from the tag body makes it linear. Measured on 100k '<': 6.0s before, 0.001s after. Adds a regression test with that input. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: phil <phil@keiailab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL py/stack-trace-exposure: order sync, flow execution and
directory batch registration returned str(exception) to API
clients. Return fixed messages instead; details stay in server
logs (logger.exception) and integration_logs.
CodeQL py/polynomial-redos: _strip_html used <[^>]+>, which is
O(n^2) on input like "<<<<...". Excluding '<' from the tag body
makes it linear. Measured on 100k '<': 6.0s before, 0.001s after.
Adds a regression test with that input.
🤖 Generated with Claude Code