Repository navigation
fix(security): Hash passwords with scrypt instead of SHA-256 - #22
Merged
Merged
Conversation
CodeQL py/weak-sensitive-data-hashing: gateway login, user creation and tenant admin creation stored unsalted SHA-256 of the password, which is cheap to brute-force offline. Add password_hasher (stdlib scrypt, random salt, constant-time compare) and use it in all three places. Existing SHA-256 hashes still verify and are replaced with scrypt on the next successful login, so no user has to reset a password. The E2E seed now uses the same hasher instead of its own SHA-256 copy. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: phil <phil@keiailab.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL py/weak-sensitive-data-hashing: gateway login, user
creation and tenant admin creation stored unsalted SHA-256 of the
password, which is cheap to brute-force offline.
Add password_hasher (stdlib scrypt, random salt, constant-time
compare) and use it in all three places. Existing SHA-256 hashes
still verify and are replaced with scrypt on the next successful
login, so no user has to reset a password. The E2E seed now uses
the same hasher instead of its own SHA-256 copy.
🤖 Generated with Claude Code