Repository navigation
Reject out-of-range ints instead of truncating - #302
Merged
Merged
Conversation
CodeQL go/incorrect-integer-conversion flagged two narrowing casts that silently wrap: - sourceShardPodDNS: "shard-4294967296" became ordinal 0 and pointed the copy Job at shard-0's primary. - parseHashBound: "0x100000000" became 0, so a ShardRange bound could cover a different hash range than written. Parse with bitSize 32 so out-of-range input returns an error. Add boundary table tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: phil <phil@keiailab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL go/incorrect-integer-conversion flagged two narrowing casts
that silently wrap:
the copy Job at shard-0's primary.
could cover a different hash range than written.
Parse with bitSize 32 so out-of-range input returns an error. Add
boundary table tests.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Signed-off-by: phil phil@keiailab.com
🤖 Generated with Claude Code