Repository navigation
Pin CI tool versions and stop piping curl - #12
Merged
Merged
Conversation
Scorecard PinnedDependencies flags hack/verify-publish.sh three times: curl output piped straight into python3 reads as download-then-run. The responses are only parsed as data, so each is now captured in a variable first; ghcr token fetching moves into one helper. CI also resolved tools at run time: golangci-lint and helm used "latest" and kubeconform ran a floating image tag, so a gate could change behaviour with no commit. They are pinned to the versions CI runs today (golangci-lint v2.14.0, helm v4.3.0, kubeconform v0.8.0 by digest). Actions and Dockerfile images were already pinned by SHA, and write permissions are already job-scoped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: phil <phil@keiailab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scorecard PinnedDependencies flags hack/verify-publish.sh three times:
curl output piped straight into python3 reads as download-then-run.
The responses are only parsed as data, so each is now captured in a
variable first; ghcr token fetching moves into one helper.
CI also resolved tools at run time: golangci-lint and helm used
"latest" and kubeconform ran a floating image tag, so a gate could
change behaviour with no commit. They are pinned to the versions CI
runs today (golangci-lint v2.14.0, helm v4.3.0, kubeconform v0.8.0 by
digest). Actions and Dockerfile images were already pinned by SHA,
and write permissions are already job-scoped.
Local:
hack/verify-publish.shpasses all 4 channels after the refactor.🤖 Generated with Claude Code