Skip to content

fix(profiles): follow the CentOS Stream cloud image rename - #164

Merged
ErenAri merged 1 commit into
Kernel-Guard:mainfrom
alban:alban_centos_image_url
Oct 8, 2026
Merged

ErenAri merged 1 commit into
Kernel-Guard:mainfrom
alban:alban_centos_image_url

Conversation

@alban

@alban alban commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

AIL:4

CentOS Stream switched its composes to the "gen2" pungi configuration on 2026-08-19 (c9s, c10s), which dropped the CentOS-Stream-GenericCloud-x86_64 image name. cloud.centos.org now serves CentOS-Stream-GenericCloud-<N>-latest.x86_64.qcow2, and the old CentOS-Stream-GenericCloud-x86_64-<N>-latest.x86_64.qcow2 URLs return HTTP 502.

Since then every CentOS Stream target fails with infra_error (download image: unexpected HTTP status 502 ...). For example, all centos-stream-9-5.14 cells in Inspektor Gadget's weekly compatibility run have been infrastructure errors since 2026-09-28: https://github.com/inspektor-gadget/inspektor-gadget/actions/runs/37271031045

This updates the URL in the CentOS Stream 9/10 profiles (including the generated kernel-sweep ones) and in make vm-images-extended.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed CentOS Stream 9 and 10 cloud image downloads by updating the image locations, preventing download errors when preparing these virtual machine images.
  • Documentation
    • Added a changelog entry describing the corrected image downloads.

CentOS Stream moved its composes to the "gen2" pungi configuration on
2026-08-19, which dropped the CentOS-Stream-GenericCloud-x86_64 image
definition and kept only CentOS-Stream-GenericCloud:

- centos-9-stream: https://gitlab.com/redhat/centos-stream/release-engineering/pungi-centos/-/commit/8bbb2eadd8b7e21d24ce63bb38b6aa9be520213f
- centos-10-stream: https://gitlab.com/redhat/centos-stream/release-engineering/pungi-centos/-/commit/fa8f81e0c342b552a34d4be86fcf14228f99bca5

cloud.centos.org now publishes the latest images as
CentOS-Stream-GenericCloud-<N>-latest.x86_64.qcow2, and the old
CentOS-Stream-GenericCloud-x86_64-<N>-latest.x86_64.qcow2 URLs return HTTP
502, so every CentOS Stream target fails with an infrastructure error.

Update the CentOS Stream 9 and 10 profiles, including the generated
kernel-sweep ones, and the vm-images-extended Makefile target.

Signed-off-by: Alban Crequy <albancrequy@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@alban
alban requested a review from ErenAri as a code owner October 8, 2026 09:24
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fe1660b1-a3aa-4d9b-ae01-2da3411aa849
📥 Commits

Reviewing files that changed from the base of the PR and between c029596 and 18b8a34.

📒 Files selected for processing (7)
  • CHANGELOG.md
  • Makefile
  • vm/profiles/centos-stream-10-6.12.yaml
  • vm/profiles/centos-stream-9-5.14-k5.14.0-725.el9.yaml
  • vm/profiles/centos-stream-9-5.14-k5.14.0-729.el9.yaml
  • vm/profiles/centos-stream-9-5.14-k5.14.0-731.el9.yaml
  • vm/profiles/centos-stream-9-5.14.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

CentOS Stream 9 and 10 image URLs now use the updated GenericCloud filenames. The change updates the extended image fetch target and affected VM profiles; cache destination names remain unchanged. The changelog records HTTP 502 errors from the previous URLs.

Changes

CentOS Stream image URLs

Layer / File(s) Summary
Update image URLs in fetch target and profiles
vm/profiles/centos-stream-*.yaml, Makefile, CHANGELOG.md
The fetch target and affected VM profiles use filenames with the stream version before the architecture suffix. The fetch target keeps its existing cache destination names. The changelog records HTTP 502 errors from the previous URLs.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 18b8a

The updated image URLs are consistent across the fetch target and profiles, with cache names unchanged. No identified issue blocks merging.

🚥 Pre-merge checks | ✅ 7 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Missing Regression Tests ⚠️ Warning The PR changes observable image-download behavior but adds no regression test. The diff changes the CentOS Stream 9/10 URLs in Makefile:219-240 and in five profile YAML files. These URLs drive downl… Add an automated regression test that loads the CentOS Stream 9/10 profiles and asserts the exact source_url values, including the generated kernel-sweep profiles. Also inspect the vm-images-extended Makefile recipe and assert that it u…
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating CentOS Stream cloud image references after the image filename rename.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Code Quality Regression ✅ Passed The pull request only corrects CentOS Stream image URL filenames in the extended image target and five matching profiles. The profile changes preserve structure, responsibilities, cache paths, and err…
Security Regression ✅ Passed No security regression is introduced. The diff changes only CentOS image filenames in Makefile and five profile files, plus the changelog. Each replacement preserves the https://cloud.centos.org h…
Full details: Missing Regression Tests

Explanation

The PR changes observable image-download behavior but adds no regression test. The diff changes the CentOS Stream 9/10 URLs in Makefile:219-240 and in five profile YAML files. These URLs drive downloads through scripts/fetch-matrix-images.sh and vm/scripts/fetch-cloud-image.sh. Existing internal/vm/profile_catalog_test.go:8-31 checks only that profiles parse and have unique IDs, and scripts/fetch-matrix-images_test.sh:20-55 uses unrelated example URLs. No test file changes exist in the PR, and no test asserts the new CentOS filenames.

Resolution

Add an automated regression test that loads the CentOS Stream 9/10 profiles and asserts the exact source_url values, including the generated kernel-sweep profiles. Also inspect the vm-images-extended Makefile recipe and assert that it uses CentOS-Stream-GenericCloud-9-latest.x86_64.qcow2 and CentOS-Stream-GenericCloud-10-latest.x86_64.qcow2 while preserving the existing cache paths. Keep the assertion independent of live network availability.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ErenAri

ErenAri commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

thanks for fixing merging it

@ErenAri
ErenAri merged commit 9468661 into Kernel-Guard:main Oct 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants