Skip to content

Do not fetch the same order twice per synchronized order #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pichatorn-A4K wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not fetch the same order twice per synchronized order #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions digicert-certcentral-caplugin/CertCentralCAPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ public async Task<AnyCAPluginCertificate> GetSingleRecord(string caRequestID)
CertCentralClient client = CertCentralClientUtilities.BuildCertCentralClient(_config);
ViewCertificateOrderResponse orderResponse = client.ViewCertificateOrder(new ViewCertificateOrderRequest((uint)orderId));

var orderCerts = GetAllCertsForOrder(orderId);
var orderCerts = GetAllCertsForOrder(orderId, orderResponse);

StatusOrder certToCheck = orderCerts.Where(c => c.certificate_id == certIdInt).First();

Expand Down Expand Up @@ -1757,10 +1757,13 @@ private List<AnyCAPluginCertificate> GetAllConnectorCertsForOrder(string caReque
/// <param name="orderId"></param>
/// <returns></returns>
/// <exception cref="COMException"></exception>
private List<StatusOrder> GetAllCertsForOrder(int orderId)
private List<StatusOrder> GetAllCertsForOrder(int orderId, ViewCertificateOrderResponse alreadyFetchedOrder = null)
{
CertCentralClient client = CertCentralClientUtilities.BuildCertCentralClient(_config);
ViewCertificateOrderResponse orderResponse = client.ViewCertificateOrder(new ViewCertificateOrderRequest((uint)orderId));
// Reuse the caller's response when it has one: GetAllConnectorCertsForOrder has just
// fetched this same order.
ViewCertificateOrderResponse orderResponse = alreadyFetchedOrder
?? client.ViewCertificateOrder(new ViewCertificateOrderRequest((uint)orderId));
if (orderResponse.Status == CertCentralBaseResponse.StatusType.ERROR)
{
string errorMessage = String.Format("Request {0} was not found in CertCentral database or is not valid", orderId);
Expand Down