Skip to content

(janitor/dependencies): remove unused js-cookie and @types/js-cookie from apps/web - #5759

Open
kilo-code-bot[bot] wants to merge 1 commit into
mainfrom
janitor/dependencies-remove-unused-js-cookie-web
Open

(janitor/dependencies): remove unused js-cookie and @types/js-cookie from apps/web#5759
kilo-code-bot[bot] wants to merge 1 commit into
mainfrom
janitor/dependencies-remove-unused-js-cookie-web

Conversation

@kilo-code-bot

@kilo-code-bot kilo-code-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes two unused dependencies from apps/web: js-cookie and its companion type package @types/js-cookie.

Dependencies removed

Package Type Version
js-cookie dependency 3.0.8
@types/js-cookie dependency 3.0.6

Evidence each was unused

  • A repository-wide search for js-cookie / jsCookie returns zero matches in any source, test, config, script, or documentation file. The only occurrences were the apps/web/package.json declaration and the lockfile.
  • No import/require/dynamic import()/import type//// <reference types> of js-cookie (or @types/js-cookie) exists anywhere in the repo.
  • knip (already configured in apps/web/knip.ts) independently reports both js-cookie (package.json:145) and @types/js-cookie (package.json:110) as unused dependencies.
  • @types/js-cookie is a type-only companion for js-cookie; with the runtime package gone it has no consumer. apps/web/tsconfig.json uses "typeRoots": ["./node_modules/@types"] (no explicit types array), so no compiler config pins it.

Dynamic, configuration, and tooling references checked

  • No package scripts reference js-cookie or its binary (it has none).
  • No next.config.mjs, jest.config.ts, playwright.config.ts, postcss.config.mjs, sentry.*.config.ts, vercel.json, components.json, knip.ts, or .babelrc reference it.
  • It is not a framework/compiler plugin, preset, loader, runtime adapter, or code-generation tool — it is a plain browser cookie library. No side-effect import or naming-convention discovery path exists.

Package publication and peer-dependency considerations

  • apps/web is a private: true Vercel application, not a published package. js-cookie/@types/js-cookie are ordinary dependencies, not peerDependencies/optionalDependencies, so no published-package contract is affected.
  • js-cookie is a leaf runtime package with no reverse dependents in this workspace; removing it cannot cause apps/web to fall back to a transitive copy, and nothing else imports it.

Validation performed

  • pnpm install --frozen-lockfile --ignore-scripts --offline — lockfile consistent with manifests.
  • pnpm run lint (apps/web, oxlint over src) — 0 warnings, 0 errors.
  • pnpm run typecheck (apps/web, tsgo --noEmit) — passed (exit 0), after building @kilocode/trpc.
  • git diff --check — clean.

Uncertainty / limitations

  • apps/web unit tests (jest) could not be run to completion: the global test setup (src/tests/setup/workerSetup.tscleanupDbForTest) requires a live PostgreSQL instance, which is unavailable in this resource-constrained environment. The failure is environmental (missing DB) and unrelated to this change; it was confirmed by the pg_tables query error. Lint + typecheck already prove no js-cookie reference remains.
  • The pnpm install step initially re-resolved unrelated peer-dependency edges in the lockfile (storybook @testing-library/dom peers, a jest/@types/node peer, and an expo snapshot). Those were discarded and the lockfile was hand-trimmed to the six expected removals so the diff stays strictly scoped to this change; --frozen-lockfile then confirmed consistency.

@kilo-code-bot kilo-code-bot Bot added the janitor Automated dead-code/duplication cleanup label Aug 31, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Unused js-cookie and @types/js-cookie removals from apps/web are correctly scoped; no remaining imports or lockfile leftovers.

Files Reviewed (2 files)
  • apps/web/package.json
  • pnpm-lock.yaml

Reviewed by grok-4.6 · Input: 54.8K · Output: 3.7K · Cached: 117.8K

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

janitor Automated dead-code/duplication cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants