(janitor/dependencies): remove unused js-cookie and @types/js-cookie from apps/web - #5759
Open
kilo-code-bot[bot] wants to merge 1 commit into
Open
(janitor/dependencies): remove unused js-cookie and @types/js-cookie from apps/web#5759kilo-code-bot[bot] wants to merge 1 commit into
kilo-code-bot[bot] wants to merge 1 commit into
Conversation
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryUnused Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 54.8K · Output: 3.7K · Cached: 117.8K Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two unused dependencies from
apps/web:js-cookieand its companion type package@types/js-cookie.Dependencies removed
js-cookie@types/js-cookieEvidence each was unused
js-cookie/jsCookiereturns zero matches in any source, test, config, script, or documentation file. The only occurrences were theapps/web/package.jsondeclaration and the lockfile.import/require/dynamicimport()/import type//// <reference types>ofjs-cookie(or@types/js-cookie) exists anywhere in the repo.knip(already configured inapps/web/knip.ts) independently reports bothjs-cookie(package.json:145) and@types/js-cookie(package.json:110) as unused dependencies.@types/js-cookieis a type-only companion forjs-cookie; with the runtime package gone it has no consumer.apps/web/tsconfig.jsonuses"typeRoots": ["./node_modules/@types"](no explicittypesarray), so no compiler config pins it.Dynamic, configuration, and tooling references checked
js-cookieor its binary (it has none).next.config.mjs,jest.config.ts,playwright.config.ts,postcss.config.mjs,sentry.*.config.ts,vercel.json,components.json,knip.ts, or.babelrcreference it.Package publication and peer-dependency considerations
apps/webis aprivate: trueVercel application, not a published package.js-cookie/@types/js-cookieare ordinarydependencies, notpeerDependencies/optionalDependencies, so no published-package contract is affected.js-cookieis a leaf runtime package with no reverse dependents in this workspace; removing it cannot causeapps/webto fall back to a transitive copy, and nothing else imports it.Validation performed
pnpm install --frozen-lockfile --ignore-scripts --offline— lockfile consistent with manifests.pnpm run lint(apps/web, oxlint oversrc) — 0 warnings, 0 errors.pnpm run typecheck(apps/web,tsgo --noEmit) — passed (exit 0), after building@kilocode/trpc.git diff --check— clean.Uncertainty / limitations
apps/webunit tests (jest) could not be run to completion: the global test setup (src/tests/setup/workerSetup.ts→cleanupDbForTest) requires a live PostgreSQL instance, which is unavailable in this resource-constrained environment. The failure is environmental (missing DB) and unrelated to this change; it was confirmed by thepg_tablesquery error. Lint + typecheck already prove nojs-cookiereference remains.pnpm installstep initially re-resolved unrelated peer-dependency edges in the lockfile (storybook@testing-library/dompeers, ajest/@types/nodepeer, and anexposnapshot). Those were discarded and the lockfile was hand-trimmed to the six expected removals so the diff stays strictly scoped to this change;--frozen-lockfilethen confirmed consistency.