feat(byok): support Bedrock API keys through Vercel - #5768
Open
chrarnoldus wants to merge 1 commit into
Open
Conversation
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryBedrock API-key BYOK validation, Vercel forwarding, persistence, and log redaction look correct with high confidence. Files Reviewed (8 files)
Reviewed by grok-4.6 · Input: 119.9K · Output: 13.1K · Cached: 246.8K Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{"apiKey":"…","region":"us-east-1"}) alongside existing IAM credentials for Vercel user and organization BYOK.Verification
No manual browser or live-provider tests were run; tests are delegated to CI as requested. No live Bedrock credentials were available.
Visual Changes
The existing AWS Bedrock credential dialog now explains both JSON formats and key expiration. No layout or component changes; screenshots not captured.
Reviewer Notes
git diff --checkpassed. Local lint and web typecheck timed out after 120 seconds each; CI is authoritative. The container has Node 22 rather than the required Node 24.apiKey/regioncontract. Live Vercel Gateway compatibility is not verified; its BYOK credential table still lists IAM fields, although its Bedrock reranking note distinguishes API keys from SigV4 credentials.