feat(web): add a hide-forks option to the repository picker - #5770
Closed
iscekic wants to merge 2 commits into
Closed
feat(web): add a hide-forks option to the repository picker#5770iscekic wants to merge 2 commits into
iscekic wants to merge 2 commits into
Conversation
…e-forked-f6d0/s1)
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental fixture update adds Files Reviewed (1 file)
Previous Review Summary (commit 5118316)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 5118316)Status: No Issues Found | Recommendation: Merge Executive SummaryHide-forks picker plumbing and one-time Files Reviewed (14 files)
Reviewed by grok-4.6 · Input: 73.7K · Output: 5.3K · Cached: 142.5K Review guidance: REVIEW.md from base branch |
Contributor
Author
|
Opened as part of an internal workflow test, if useful, please take over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
repo-picker:hide-forkslocal-storage key.N forks hiddenwhen the filter is on.forkflag through to the picker for Code Reviewer, Security Agent, Auto Triage, and Auto Fix.forkflag triggers one refetch, so the flag backfills without a migration.Why
Issue #4498 asks for a way to hide forked repositories when a user selects repositories to watch. An account with many forks makes the picker hard to read. The GitHub API already returns the
forkflag, but the picker's data path dropped it.Verification
backendpassed: no changed service.Notes for the reviewer
forkis optional on the repository types. A repository cached before this change reportsfork: undefinedand stays listed until the backfill refetch replaces it.repository-multi-select-selection.tsand have unit tests.