Allow custom callbacks in proxy generator - #540
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new value
direct-callbackfor annotationorg.freedesktop.DBus.Method.Async.ClientImpl, which generates proxy method interfaces that accept custom callback as an argument.This (in my opinion) is infinitely more convenient to use than standard
callback-generated interfaces that require overriding virtual functions in a derived proxy class to implement a callback, which implies that we need to create a separate derived class for each separate access scenario of the interface.This change also adds empty default implementation to the signal handlers, removing the need to implement them, in case you don't use them.