Skip to content

Fix the In-Depth Example in the docs to return bytes #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fjvbn2003 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the In-Depth Example in the docs to return bytes #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ import python_multipart

def simple_app(environ, start_response):
start_response('200 OK', [('Content-type', 'text/plain')])
return ['Hashes:\n']
return [b'Hashes:\n']

from wsgiref.simple_server import make_server
httpd = make_server('', 8123, simple_app)
Expand Down Expand Up @@ -117,7 +117,7 @@ import python_multipart
from python_multipart.multipart import parse_options_header

def simple_app(environ, start_response):
ret = []
ret = [b'Hashes:\n']

# Python 2 doesn't have the "nonlocal" keyword from Python 3, so we get
# around it by setting attributes on a dummy object.
Expand All @@ -135,7 +135,7 @@ def simple_app(environ, start_response):

# Our current part is done, so we can finish the hash.
def on_part_end():
ret.append("Part hash: %s" % (g.hash.hexdigest(),))
ret.append(b"Part hash: %s\n" % (g.hash.hexdigest().encode(),))

# Parse the Content-Type header to get the multipart boundary.
content_type, params = parse_options_header(environ['CONTENT_TYPE'])
Expand Down
Loading