Repository navigation
feat(toolbar): the group editor's add list follows the field switches - #1052
Merged
Merged
Conversation
A preset whose target belongs only to turned-off fields isn't offered when adding to a group, the same check as the toolbar editor's palette. Presets already in the group stay. Part of #806
KnifeLemon
approved these changes
Nov 3, 2026
KnifeLemon
left a comment
Owner
There was a problem hiding this comment.
@SeoJCalive #1036 리뷰에서 말한 그룹 편집기 추가 목록까지 바로 이어서 올려 줘서 고마워요.
- 추가 목록: 툴바 편집기의 사용 가능한 프리셋과 똑같이
FormatFields.IsShown하나로 걸러서, 두 목록이 서로 어긋날 일이 없어요. 다른 분야에도 속한 EOT는 그대로 나와요. - 이미 들어 있는 항목: 그대로 남아요(규칙 7). 빼면 꺼진 분야인 동안은 목록에 다시 나오지 않는데, 팔레트와 같은 동작이라 맞아요.
- 시험: 남는 항목, 걸러지는 항목, 다른 분야 덕에 남는 항목, 스위치를 다시 켰을 때까지 다 확인하고,
finally로 설정을 되돌려 놓아서 다른 시험에 영향이 없어요.
CI도 모두 초록이라 머지할게요. #806의 남은 부분은 이슈에서 이어서 정리해요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Part of #806. Follow-up to #1036, as asked in the review: the group editor's add list now follows the field switches, like the toolbar editor's Available presets.
FormatFields.IsShown), so a format that is also in a field that's on stays (EOT with Fonts off, because it is also in Old formats).Type of change
How was it tested?
On this branch on top of
mainat885e7f62(with #1036 and #1046).dotnet format --verify-no-changesmain, none of them in a file this PR touches.dotnet test: the group editor, field switch, toolbar editor and Fields page App tests (30/30). CI covers the rest.Presets_of_turned_off_fields_are_not_offered_but_members_stay: with Fonts off, a TTF member stays, OTF isn't offered, EOT and PNG are; after removing TTF it isn't offered; with every field on, OTF is offered again.IsShownfilter, the new test fails (Assert.DoesNotContain); with it back, the group editor tests pass.Screenshots (UI changes)
Korean, Fonts off, the add list opened (rendered headlessly on #1036's head
caf5e52f, before #1046, which only changes hover and cursors in this window). Before, TTF follows DWG; after, EOT does, and TTF, OTF, WOFF and WOFF2 are gone (140 → 136 presets).Checklist
src/Filee.App/Assets/i18n/*.jsonfiles (none added)THIRD-PARTY-NOTICES.md(none added)