[fluentmoheshwar]

Tip

Start the title with a prefix so the PR is labeled automatically: feat: fix: docs: ci: build: i18n:
Example: fix(hwp): keep tables when converting to DOCX

What does this change?

Added Bengali as a language option. It is spoken by over 30 milion peoples.

Type of change

• Bug fix
• New feature or improvement
• New format or engine
• Translation
• Documentation
• Build, CI or dependencies

How was it tested?

• dotnet format --verify-no-changes
• dotnet test
• Tried it in the app (what you converted or clicked, and on which OS):

Screenshots (UI changes)

Checklist

• New UI strings are in all src/Filee.App/Assets/i18n/*.json files
• New third-party code or binaries are listed in THIRD-PARTY-NOTICES.md
• The PR does one thing (unrelated changes go in a separate PR)

[KnifeLemon]

Thanks for the translation, @fluentmoheshwar! It needs one fix before it can go in.

Must fix: 67 keys were translated along with the text

Some words were replaced everywhere in bn-BD.json, including inside the key names, so Filee can't find those strings and they won't show in Bengali:

error.পিডিএফ_no_tables        should be  error.pdf_no_tables
error.পিডিএফ_passওয়ার্ড_gone   should be  error.pdf_password_gone
engine.পিডিএফium.description  should be  engine.pdfium.description
engine.মার্কডাউন .name         should be  engine.markdown.name

Only three words cause all 67: পিডিএফ (pdf), ওয়ার্ড (word) and মার্কডাউন (markdown, with a space after it). Putting the English words back in the keys only fixes them; the translated values can stay as they are. Comparing the keys with en.json will confirm none are left.

Please fix too

• README.md: the new link sits after Italiano, which has no · after it, so the two run together, and the new line ends with a stray ·.
• README.bn-BD.md: the language list has Bengali twice, as the bold entry and as a link to itself at the end.
• SetupOptions.cs:12: bn-BD landed inside the zh-CN (Inno: zhcn) note and left a stray comma. It belongs at the end of the list on the next line.

We'll handle the rest

error.p7m_* and engine.p7m.* (7 keys) were added to main after you started, so you couldn't have had them. We'll add those ourselves, so you don't need to chase them.

Everything else looks right: the placeholders match en.json, the font is pinned by hash in fetch-fonts.ps1, and it's listed in the notices. CI was waiting for approval on this PR, so I've started it; it will show the state of these keys too.

[fluentmoheshwar]

Thanks for the translation, @fluentmoheshwar! It needs one fix before it can go in.

Must fix: 67 keys were translated along with the text

Some words were replaced everywhere in bn-BD.json, including inside the key names, so Filee can't find those strings and they won't show in Bengali:

error.পিডিএফ_no_tables        should be  error.pdf_no_tables
error.পিডিএফ_passওয়ার্ড_gone   should be  error.pdf_password_gone
engine.পিডিএফium.description  should be  engine.pdfium.description
engine.মার্কডাউন .name         should be  engine.markdown.name

Only three words cause all 67: পিডিএফ (pdf), ওয়ার্ড (word) and মার্কডাউন (markdown, with a space after it). Putting the English words back in the keys only fixes them; the translated values can stay as they are. Comparing the keys with en.json will confirm none are left.

Please fix too

• README.md: the new link sits after Italiano, which has no · after it, so the two run together, and the new line ends with a stray ·.
• README.bn-BD.md: the language list has Bengali twice, as the bold entry and as a link to itself at the end.
• SetupOptions.cs:12: bn-BD landed inside the zh-CN (Inno: zhcn) note and left a stray comma. It belongs at the end of the list on the next line.

We'll handle the rest

error.p7m_* and engine.p7m.* (7 keys) were added to main after you started, so you couldn't have had them. We'll add those ourselves, so you don't need to chase them.

Everything else looks right: the placeholders match en.json, the font is pinned by hash in fetch-fonts.ps1, and it's listed in the notices. CI was waiting for approval on this PR, so I've started it; it will show the state of these keys too.

Sorry, I forgot to run dotnet test after doing a find and replace. I will leave a comment after fixing these issues

[fluentmoheshwar]

Done