Repository navigation
fix(archive): keep Mark of the Web on a pack-into-one archive - #1232
Merged
Merged
Conversation
"One ZIP" and the other pack-into-one presets go through RunCombinedAsync, which never passed the mark on, so an archive built from downloaded files came out unmarked. If any packed file has a mark, the archive now gets it. Files inside a folder count too. Links inside a folder are skipped, as the packer leaves them out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
"One ZIP" and the other pack-into-one presets never passed on Mark of the Web, so an archive built from downloaded files came out unmarked. Converted files already keep the mark (
RunFileAsync);RunCombinedAsyncdidn't. Now, if any packed file has a mark, the archive gets it..shx,.dbf, ...) and the files inside a folder count as packed files.AttributesToSkip = FileAttributes.ReparsePoint, as inArchiveExtractor.PassOnMark): the packer leaves them out, so what they point at isn't in the archive.Type of change
How was it tested?
dotnet format --verify-no-changes(changed files)dotnet test:Filee.Core.Testsin full andArchiveTestsinFilee.Engines.Tests, on WindowsNew tests in
JobQueueTests, next toAn_output_converted_from_a_file_from_the_internet_keeps_its_mark_of_the_web, usingFakeCombiner:An_archive_packed_from_a_file_from_the_internet_has_its_mark_of_the_web: fails without the fix. Covers a marked file that isn't first, a marked file deep in a folder, and no mark at all.A_link_in_a_folder_being_packed_gives_the_archive_no_mark_of_the_web: a junction to a marked file outside the folder. Fails when links are followed.Checklist
src/Filee.App/Assets/i18n/*.jsonfiles (none)THIRD-PARTY-NOTICES.md(none)🤖 Generated with Claude Code