Skip to content

feat: queue several files on the Home page before converting - #865

Closed
arielsrossi wants to merge 1 commit into
KnifeLemon:mainfrom
arielsrossi:feat/multi-file-queue
Closed

arielsrossi wants to merge 1 commit into
KnifeLemon:mainfrom
arielsrossi:feat/multi-file-queue

Conversation

@arielsrossi

@arielsrossi arielsrossi commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

What does this change?

On the Home page, files dropped in the drop zone or picked with a double-click now join a queue below it, instead of opening the donut for each drop. Files can be added over several drops until the queue holds what you want. "Choose action" opens the donut for the queue in the order shown, and the queue empties once that conversion finishes.

  • The first file sets the type: files of another format are refused, with a notice over the drop zone (the window is dimmed behind it). The notice closes with its X.
  • Each queued file shows its first page (PDF) or its picture, numbered in the theme's accent circle, and can be dragged to another place or removed with its X.
  • A merge started from the queue keeps the queue's order and does not open the "Choose the merge order" window. Merging pictures still opens it, for the layout.
  • Drops from a browser still open the donut at the drop position, as before.

Type of change

  • New feature or improvement
  • Translation (the seven new strings, in all 19 language files)

How was it tested?

  • dotnet format --verify-no-changes
  • dotnet test: the new FileQueueTests, MergeOrderTests, LocalizationTests, BrowserDropTests and RecentConversionTests passed on an earlier build of this branch. Two RenderTests fail on machines with a pt-BR culture (Preset_editor_saves_every_frame_only_for_png_and_jpg and Preset_editor_shows_playback_speed_only_for_targets_that_keep_animations): they compare number text, and the failure is not caused by this change, though I did not confirm it on main. The full suite was not re-run after the last few commits.
  • Tried it in the app: dropped and picked PDFs and PNGs on Windows 10, checked the type refusal, reordering, removal, the merge order, and the queue clearing after a conversion.

Screenshots (UI changes)

Checklist

  • New UI strings are in all src/Filee.App/Assets/i18n/*.json files
  • New third-party code or binaries are listed in THIRD-PARTY-NOTICES.md (none added)
  • The PR does one thing (the Home page queue, and the merge order that follows from it)

🤖 Generated with Claude Code

Files dropped on the Home page or picked with the double-click dialog join a
queue below the drop zone instead of opening the donut at once. The first file
sets the type: files of another format are refused with a notice over the drop
zone, with the window dimmed behind it. Each queued file shows its first page
(PDF) or its picture, numbered in the theme's accent circle, can be dragged to
another place, and can be removed with its X. "Choose action" opens the donut
for the queue in that order, and the queue empties once that conversion
finishes. A merge started from the queue keeps the order and does not open the
merge-order chooser (merged pictures still do, for their layout).

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the feature New features label Oct 31, 2026
@arielsrossi
arielsrossi force-pushed the feat/multi-file-queue branch from 7fa8400 to bea922d Compare October 31, 2026 04:29

@KnifeLemon KnifeLemon left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arielsrossi, and welcome! I've approved the CI run, so the checks will show up here.

First: this needs an issue

This changes what the Home drop zone does for everyone: a drop or a double-click no longer opens the donut, it fills a queue. A change like that we agree on in an issue first, so other people can weigh in. It's close to #860 (reorder and remove before merging) and discussion #669 (thumbnails and order before an images → PDF merge), which ask for related things in different places.

Could you open an issue with the idea and link those two? A few questions to cover there:

  • Should the queue replace the donut on a drop, or come in alongside it (for example only when a second file is dropped)?
  • Where does it live: the Home page only, or also the Edit PDF pages window, which already has a thumbnail strip with reordering?

Bugs, for whichever version comes next

  1. The queue can clear when nothing was converted. FinishSentQueue (HomePageViewModel.cs) looks through the whole history for an entry that holds all the sent paths. If those files were converted before, the next HistoryChanged, for any job, empties the queue, even when the donut was cancelled. Only entries added after MarkSentToDonut should count.
  2. One format per queue is stricter than the donut. FileQueue.Add compares format.Id, so JPG and PNG can't share a queue. They share the image donut, though, and Merge images and Merge PDF take both. The rule should follow the donut (its profile), not the exact format.
  3. The notice dims the whole window with a hard-coded #A6000000 (MainWindow.axaml). That's heavy for a one-line notice, and colours should come from the theme's brushes so all the themes, and high contrast, still work.
  4. Reordering works only with the mouse. The cards can be dragged, but there's no keyboard way (for example Alt+Up / Alt+Down on a focused card) to move one.

Tests

The PR says the full dotnet test wasn't run after the last commits. CI will show that now.

I'm marking this as changes requested until there's an issue. Happy to continue there.

@arielsrossi

Copy link
Copy Markdown
Contributor Author

Closing in favour of #928, which follows issue #927. Not a rejection of the work: the old branch will stay on my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants