Repository navigation
Conversation
Pin pmcore =0.29.0, which brings pharmsol 0.29.2. ODE dose inputs and their scales now stay on the derivative RHS instead of being declared as separate routes; analytical models keep explicit routes, lag and fa. - `R[j]`/`rateiv[j]` and `B[j]`/`bolus[j]` may be a standalone additive term or one exact product with a scale, in either operand order. - A bolus scale may not depend on state or dose inputs. - A PM_model rebuilt from another PM_model renders its DSL from `arg_list` rather than inheriting a previously rendered string, which could be stale. - Regenerate data/*.rda, which the data-currency test requires after any change to the R6 method bodies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins
pmcore = "=0.29.0"(pharmsol 0.29.2).ODE dose inputs and their scales now stay on the derivative RHS instead of being declared as separate routes; analytical models keep explicit routes,
lagandfa.R[j]/rateiv[j]andB[j]/bolus[j]may be a standalone additive term or one exact product with a scale, in either operand order.PM_modelrebuilt from anotherPM_modelrenders its DSL fromarg_listinstead of inheriting a previously rendered string, which could be stale.data/*.rda, which the data-currency test requires after any change to the R6 method bodies.Full testthat suite passes.