Repository navigation
Conversation
`shipped example objects embed the current R6 method bodies` compares the bodies frozen in data/*.rda against the live R6 generators. covr rewrites every R6 method body in place when it instruments a package (covr:::traverse_R6), so the instrumented generator can never match the uninstrumented stored copy and the test-coverage workflow has failed on every run since the test was added in 6b50eee. skip_on_covr() keeps the assertion running under R CMD check, where the bodies are not instrumented and the check does its real job.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
This PR skips the R6 method-body consistency test during covr instrumentation while retaining normal checks.
Changes:
- Adds a
covr-specific test skip. - Keeps R6 member validation active.
File summaries
| File | Changes |
|---|---|
tests/testthat/test-data-currency.R |
Skips the method-body test under covr. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 62.73% 63.11% +0.38%
==========================================
Files 51 52 +1
Lines 22410 22548 +138
==========================================
+ Hits 14059 14232 +173
+ Misses 8351 8316 -35 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise CI will fail