Repository navigation
Conversation
A length(prior) == 1 guard sent every data frame or PM_result prior back to a Sobol grid without a message, so PM_result$continue() restarted from scratch. A PM_result now uses its final support points, a data frame is used as is, and any other value is an error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTyUgJEd5uCEmv9qYrv8dC
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new PM_result test errors in the earlier Sobol guard before exercising the changed behavior.
1 open finding
What changed in this PR
Updates prior handling so fits can reuse support points instead of silently falling back to Sobol.
Changes:
- Accepts
PM_resultand data-frame priors. - Rejects unsupported prior values.
- Adds mocked prior-handling tests.
| File | Description |
|---|---|
R/PM_model.R |
Expands prior validation and conversion. |
tests/testthat/test-pm-fit-prior-parameters.R |
Tests object priors and rejection behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+196
to
+198
| params <- tolower(names(NPex$model$model_list$pri)) | ||
| prior_df <- make_prior_df(params) | ||
| prior_result <- structure(list(final = list(popPoints = prior_df)), class = "PM_result") |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
==========================================
+ Coverage 64.77% 64.88% +0.10%
==========================================
Files 52 52
Lines 22964 22984 +20
==========================================
+ Hits 14876 14914 +38
+ Misses 8088 8070 -18
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug. A
length(prior) == 1guard sent every data-frame orPM_resultprior back to a Sobol grid, with no message. As a result,PM_result$continue()restarted from scratch.Fix.
PM_resultprior uses its$final$popPoints.Tests. Mocked fits cover a
PM_resultprior, a data-frame prior and an unsupported prior.Note. This changes
PM_model$fit, sotest-data-currency.Rwill fail untildata/*.rdais regenerated.🤖 Generated with Claude Code
https://claude.ai/code/session_01GTyUgJEd5uCEmv9qYrv8dC
Generated by Claude Code