Repository navigation
Conversation
A cycles = 0 run writes a single row with cycle 0, and rep(1:0, ...) gave two values, so creating the cycle object failed and $cycle$status was empty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTyUgJEd5uCEmv9qYrv8dC
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation fixes the reported failure with low risk; the noted test assertion weakness is non-blocking.
1 open finding
What changed in this PR
Fixes cycle-object creation for cycles = 0 runs by preserving cycle identifiers from generated output.
Changes:
- Derives gamma/lambda cycle indices from
raw$cycle. - Adds a regression test for zero-cycle prior runs.
| File | Description |
|---|---|
R/PM_cycle.R |
Corrects zero-cycle gamma/lambda indexing. |
tests/testthat/test-pm-cycle-posterior.R |
Tests zero-cycle object creation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| expect_length(run2$cycle$status, 1) | ||
| expect_equal(run2$cycle$data$objective$cycle, 0) | ||
| expect_true(all(run2$cycle$data$gamlam$cycle == 0)) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 64.77% 64.84% +0.06%
==========================================
Files 52 52
Lines 22964 22965 +1
==========================================
+ Hits 14876 14891 +15
+ Misses 8088 8074 -14
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug. After a
cycles = 0run, creating the cycle object fails with`cycle` must be size 1, not 2, and$cycle$statusis empty. The code usedrep(1:n_cyc, ...), and withn_cyc = 0that isrep(1:0, ...), which gives two values.Fix. Build the gamlam cycle index from the
cyclecolumn itself.Test. A real
cycles = 0fit. The test fails onmain.🤖 Generated with Claude Code
https://claude.ai/code/session_01GTyUgJEd5uCEmv9qYrv8dC
Generated by Claude Code