fix(PM_compare): detect "Stopped (converged)" status

[mhovd]

Bug. The converged column of PM_compare() used a case-sensitive grepl("Converged"). PMcore writes the status as "Stopped (converged)", so the column was FALSE for every converged run.

Fix. Match case-insensitively, in a small helper.

Test. Checks the old and new status strings.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GTyUgJEd5uCEmv9qYrv8dC

---

Generated by Claude Code

[Copilot]

🟢 Approval recommended

The focused fix correctly addresses the status mismatch with adequate regression coverage.

0 open findings

What changed in this PR

Updates PM_compare() to recognize PMcore’s lowercase converged status.

Changes:

• Adds case-insensitive convergence detection.
• Tests legacy, PMcore, non-converged, and empty statuses.

File	Description
R/​PM_compare.R	Adds and uses the status helper.
tests/​testthat/​test-pm-compare-converged.R	Covers convergence status variants.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.78%. Comparing base (ef474a1) to head (99de227).

Files with missing lines	Patch %	Lines
R/PM_compare.R	50.00%	1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   64.77%   64.78%           
=======================================
  Files          52       52           
  Lines       22964    22965    +1     
=======================================
+ Hits        14876    14877    +1     
  Misses       8088     8088           

Files with missing lines	Coverage Δ
R/PM_compare.R	0.24% <50.00%> (+0.24%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.