Repository navigation
Conversation
%||% is only in base R from 4.4, so the plotting helpers failed on R 4.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTyUgJEd5uCEmv9qYrv8dC
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted import consistently fixes the missing operator on older supported R versions.
0 open findings
What changed in this PR
Imports rlang’s %||% operator to restore plotting compatibility with R versions before 4.4.
Changes:
- Adds
%||%to the rlang roxygen imports. - Updates the generated namespace accordingly.
| File | Description |
|---|---|
R/Pmetrics-package.R |
Declares the `% |
NAMESPACE |
Registers `% |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
=======================================
Coverage 64.77% 64.77%
=======================================
Files 52 52
Lines 22964 22964
=======================================
Hits 14876 14876
Misses 8088 8088 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug. On R < 4.4, the plotting helpers (for example the covariate plot) fail with
could not find function "%||%". Base R only has%||%from 4.4.Fix. Import
%||%from rlang (@importFrom rlang %||%). Tested on R 4.3.3:NPex$cov$plot(v ~ wt)fails onmainand works with this change.🤖 Generated with Claude Code
https://claude.ai/code/session_01GTyUgJEd5uCEmv9qYrv8dC
Generated by Claude Code