Repository navigation
Conversation
This has been fixed before, just covering the model surface too
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Truncating comparisons can let the new regression tests pass without exercising the derivative.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds regression coverage for whole-number derived values used in ODE derivatives and conditionals.
Changes:
- Adds multi-time prediction helper.
- Tests direct and conditional derivative scaling.
| File | Description |
|---|---|
tests/dsl_constant_derived.rs |
Adds derived-equation regression tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+44
to
+48
| Ok(predictions | ||
| .predictions() | ||
| .iter() | ||
| .map(|prediction| prediction.prediction()) | ||
| .collect()) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
=======================================
Coverage 84.75% 84.75%
=======================================
Files 78 78
Lines 35818 35818
=======================================
Hits 30356 30356
Misses 5462 5462 🚀 New features to boost your workflow:
|
Contributor
|
Bencher Report| Project | pharmsol |
| Branch | dsl-tests-integer |
| Testbed | mhovd-pgx |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🚨 6 Alerts
🐰 View full continuous benchmarking report in BencherThis branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been fixed before, just covering the model surface too