Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bw_functional/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,12 @@ def _check_parameterized_exchange_for_allocation(_, name):
continue
process.allocate()

def _check_and_update(dataset):
def _check_and_update(sender, dataset=None, **kwargs):
# bw2data 4.7 and earlier send the ProjectDataset as the sender; 4.8+ send
# the ProjectManager as the sender and the ProjectDataset as dataset=.
if dataset is None:
dataset = sender

if dataset.data is None:
dataset.data = {}
dataset.save()
Expand Down
27 changes: 27 additions & 0 deletions tests/test_project_signal_api.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
"""bw2data 4.7 vs 4.8 project_changed receiver compatibility."""


class _FakeProjectDataset:
name = "compat-test"
data = {"bw_functional_version": "already-current"}

def save(self):
raise AssertionError("save should not run when version is already current")


def test_check_and_update_accepts_bw2data_47_positional_sender(monkeypatch):
import bw_functional as bf

monkeypatch.setattr(bf, "latest", "already-current")
ds = _FakeProjectDataset()
# bw2data ≤4.7: project_changed.send(dataset)
bf._check_and_update(ds)


def test_check_and_update_accepts_bw2data_48_dataset_kwarg(monkeypatch):
import bw_functional as bf

monkeypatch.setattr(bf, "latest", "already-current")
ds = _FakeProjectDataset()
# bw2data 4.8+: project_changed.send(manager, dataset=dataset)
bf._check_and_update(object(), dataset=ds)
Loading