Added persist to the DataSession model - #137
Merged
Merged
Conversation
…ment command to delete all non-persistant datasessions after 30 days
capetillo
approved these changes
Sep 22, 2026
capetillo
left a comment
capetillo
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me but I don't have enough expertise to review the yaml file
jashan-lco
approved these changes
Sep 22, 2026
| runAsGroup: 1000 | ||
| readOnlyRootFilesystem: true | ||
| env: | ||
| - name: CONTAINER_TYPE |
Contributor
There was a problem hiding this comment.
What's the purpose of this ENV var? Don't see it mentioned anywhere else in this diff, so just making sure it actually exists.
Contributor
Author
There was a problem hiding this comment.
It basically specifies a cache key prefix for the filecache that uses a shared redis instance. It doesn't really matter for this container since it shouldn't be interacting with files anyway, but might as well give it its own value. Its main purpose is so the worker pods and server pods have their own separate caches in the shared redis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
persistboolean field to theDataSessionmodel defaulting to False.persist=Falseif they were created > 30 days ago.response_fieldsparam to requests for DataSessions which, if specified, limits the returned fields to only those specified. The default without it specified is to return all fields. This is because we have a tremendous amount of data in theoperationsandinput_datafields of DataSessions which we don't want or need returned when just sending a PATCH request to updatepersist.