Conversation
Honor IsEnabled() in middleware so custom Auditor mocks are not invoked when disabled, matching the documented NewAuditMiddleware contract. Co-authored-by: Cursor <cursoragent@cursor.com>
Cover nil/disabled/enabled LogAuditEvent paths, global init once-semantics, and uninitialized warn behavior so custom Auditor mocks are protected. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuditMiddleware.LogAuditEventnow returns early whenclient == nilor!client.IsEnabled(), matching the documentedNewAuditMiddleware/InitializeGlobalAuditcontract.Auditor, context/request forwarding, global init once-semantics, uninitialized warn).Related: discovered while wiring audit in openndx-core; openndx/openndx-core#585 deferred asserting no events when disabled until Argus honors
IsEnabled()in middleware.Test plan
cd pkg/audit && go test -count=1 .cd pkg/audit && go vet .pkg/auditrelease tag so openndx-core can bump and assertlen(mockClient.receivedEvents) == 0inTestLogAuditEventWhenNotConfigured