Repository navigation
test: exercise service-worker push and notification-click behavior - #1812
Open
Maxwell-tom wants to merge 3 commits into
Open
Maxwell-tom wants to merge 3 commits into
Maxwell-tom wants to merge 3 commits into
Conversation
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 24, 2026
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 24, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 24, 2026 09:46
a67b1f0 to
414782d
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 24, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 24, 2026 09:48
414782d to
55b91f5
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 24, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 24, 2026 09:51
55b91f5 to
250ce94
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 24, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 24, 2026 11:30
250ce94 to
cd2c904
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 24, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 24, 2026 11:50
cd2c904 to
95ebf3e
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 24, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 24, 2026 11:52
95ebf3e to
bf5f135
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 24, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 24, 2026 11:54
bf5f135 to
99e4508
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 29, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 29, 2026 07:37
99e4508 to
a40daff
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 29, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 29, 2026 07:39
a40daff to
c2264c4
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 29, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 29, 2026 07:42
c2264c4 to
6b0756e
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 29, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 29, 2026 08:00
6b0756e to
93746da
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 29, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 29, 2026 08:01
93746da to
b71cc1e
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 29, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 29, 2026 09:18
b71cc1e to
b25b0c0
Compare
Maxwell-tom
added a commit
to Maxwell-tom/flowfi
that referenced
this pull request
Oct 29, 2026
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 29, 2026 09:20
b25b0c0 to
602058e
Compare
Maxwell-tom
force-pushed
the
feat/issue-1712-test-exercise-service-worker-push-and
branch
from
October 29, 2026 09:23
602058e to
2a38baa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds direct test coverage for
frontend/public/sw.js, the service worker that handles push events and notification clicks. Previously, notification tests mocked the subscribe/unsubscribe helpers and never executed the worker script, so regressions in push payload parsing,waitUntillifetimes, window reuse, oropenWindowbehavior could go undetected. The new harness runs the actual script and asserts on those paths.Related Issue
Changes
🧪 Service Worker Test Harness
[ADD]
frontend/src/__tests__/service-worker.test.tspublic/sw.jsinside a worker-like harness.openWindowbehavior), includingevent.waitUntillifetime assertions.[MODIFY]
frontend/public/sw.js[MODIFY]
frontend/src/__tests__/notifications.test.tsx[MODIFY]
frontend/src/__tests__/setup.tsself,clients,registration) used by the harness.Verification Results
service-worker.test.tsevent.waitUntilservice-worker.test.tsCloses #1712