Skip to content

[fix] RefinanceLoanModal and ExtensionLoanModal sign and submit directly with no confirmation step #1886

New issue
New issue
Closed
#2181
#1932
Closed
[fix] RefinanceLoanModal and ExtensionLoanModal sign and submit directly with no confirmation step#1886
#2181
#1932
Assignees
khaylebfortune
Labels
Stellar WaveIssues in the Stellar wave programbugSomething isn't workingfrontendIssues related to frontend development

Description

@K1NGD4VID
K1NGD4VID
opened on Sep 27, 2026

File/location: frontend/src/app/components/loan-wizard/ExtensionLoanModal.tsx:67-121,frontend/src/app/components/loan-wizard/RefinanceLoanModal.tsx:82-138

Description:
Both modals' handleSubmit build, sign (via Freighter), and submit the on-chain transaction directly from the primary button click with no intermediate preview/confirmation step. This is inconsistent with LoanRepaymentForm, RemittanceForm, and StepFinalSignature, which all show a TransactionPreviewModal requiring explicit acknowledgment before signing — extending a loan term or refinancing principal/rate are irreversible on-chain actions that skip this established safeguard.

Acceptance Criteria:

  • Refinance and Extension flows show a confirmation/preview step (reusing TransactionPreviewModal or an equivalent) before triggering wallet signing
  • User can cancel out of the preview without having signed anything
  • Test covers cancel-before-sign for both modals

Notes:
Closed issue #863 ('Build refinance and extend loan UI flows') asked these flows to use 'the same build → sign → submit transaction lifecycle as repay,' but the repay flow itself goes through a confirmation preview, so this appears to be an unmet acceptance criterion of that closed issue rather than a new feature request.

Filed via automated codebase sweep (frontend / fix).

Activity

  1. K1NGD4VID
    added
    bugSomething isn't working
    frontendIssues related to frontend development
    on Sep 27, 2026

  2. shobhamerabacha-star commented on Sep 27, 2026

    @shobhamerabacha-star
    shobhamerabacha-star
    on Sep 27, 2026

    Hello team,

    I would love to take this on. My planned approach:

    • Deliver [fix] RefinanceLoanModal and ExtensionLoanModal sign and submit directly with no confirmation step with proper loading/error states and clean component architecture.
    • Add component unit tests verifying user interactions and rendering states.

    Excited to work on this—please assign to me and I will submit a clean PR shortly!

  3. Simultech369 commented on Sep 28, 2026

    @Simultech369
    Simultech369
    on Sep 28, 2026

    Hello Maintainers!

    Autonomous Council implementation and test verification for this issue has been completed, passing all test suites across 5 review surfaces, and submitted in PR #1932 (#1932).

    Stellar Wave 9 Formalization & 1-Click Acceptance:

    Maintainer Action: To credit this work for Wave 9 on Drips, please assign @Simultech369 to this issue or review and accept via the Drips Maintainer Portal:
    Review / Accept on Drips Maintainer Dashboard

    Thank you for your review!

  4. drips-wave
    added
    Stellar WaveIssues in the Stellar wave program
    on Oct 21, 2026

  5. Yemmy88 commented on Oct 21, 2026

    @Yemmy88
    Yemmy88
    on Oct 21, 2026 – with Drips Wave

    @Yemmy88 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I have read through this issue and I can resolve it, please allow me work on it.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Yemmy88 to this issue.

  6. iyiade08 commented on Oct 21, 2026

    @iyiade08
    iyiade08
    on Oct 21, 2026 – with Drips Wave

    @iyiade08 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello, I’d be interested in contributing to this issue and would appreciate the chance to work on it. Thank you for considering my application.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @iyiade08 to this issue.

  7. vijay11149 commented on Oct 21, 2026

    @vijay11149
    vijay11149
    on Oct 21, 2026 – with Drips Wave

    @vijay11149 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I WOULD LOVE TO WORK ON THIS ISSUE

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @vijay11149 to this issue.

  8. elonwachineke-dot commented on Oct 21, 2026

    @elonwachineke-dot
    elonwachineke-dot
    on Oct 21, 2026 – with Drips Wave

    @elonwachineke-dot has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello Maintainer, I would appreciate it if you could review my application and assign the issues to me. I am ready to get started and will ensure timely delivery.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @elonwachineke-dot to this issue.

  9. Tamziycode commented on Oct 21, 2026

    @Tamziycode
    Tamziycode
    on Oct 21, 2026 – with Drips Wave

    @Tamziycode has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello Maintainer, I’ve gone through the issue carefully and understand the requirements. I’m confident I can handle the task and deliver a solution that meets the expected criteria. I’d appreciate it if you could assign the issue to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Tamziycode to this issue.

  10. amossamuel851-tech commented on Oct 21, 2026

    @amossamuel851-tech
    amossamuel851-tech
    on Oct 21, 2026 – with Drips Wave

    @amossamuel851-tech has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello, I am a fullstack developer with years of experience
    on building web3 and web3 applications, I have reviewed this project
    please assign the issue to be fixed. ETA 1hr

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @amossamuel851-tech to this issue.

  11. khaylebfortune commented on Oct 21, 2026

    @khaylebfortune
    khaylebfortune
    on Oct 21, 2026 – with Drips Wave
    Contributor

    @khaylebfortune has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello Maintainer, please assign.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @khaylebfortune to this issue.

  12. sebas11042 commented on Oct 21, 2026

    @sebas11042
    sebas11042
    on Oct 21, 2026 – with Drips Wave

    @sebas11042 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer! I'd like to work on this issue. I'll add a transaction preview and confirmation step to both refinance and extension flows, reusing the existing TransactionPreviewModal pattern. I'll ensure cancellation never triggers wallet signing and add tests covering both flows. Thanks for considering my application!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @sebas11042 to this issue.

  13. macsonfleek commented on Oct 21, 2026

    @macsonfleek
    macsonfleek
    on Oct 21, 2026 – with Drips Wave

    @macsonfleek has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi maintainer, please assign, I can fix this shortly.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @macsonfleek to this issue.

  14. K1NGD4VID
    assigned
    khaylebfortune
    on Oct 21, 2026

  15. drips-wave commented on Oct 21, 2026

    @drips-wave
    drips-waveBot
    on Oct 21, 2026 – with Drips Wave

    Congratulations, @khaylebfortune! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @khaylebfortune: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  16. K1NGD4VID
    closed this as completedin #2181on Oct 28, 2026

  17. drips-wave commented on Oct 28, 2026

    @drips-wave
    drips-waveBot
    on Oct 28, 2026 – with Drips Wave

    This issue has been marked as completed by a Drips Wave moderator for @khaylebfortune as part of the Stellar Wave Program's 10th Wave 🥳

    Moderator's reason: [Auto-assessed] The PR #2181 was merged by maintainers on 2026-10-28 (mergedAt: 2026-10-28T14:11:58Z) and successfully fixes error handling and state management for confirmed mutations used across loan wizard flows. The contribution is clean, tested, and accepted.

    😎 @khaylebfortune: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

    ℹ️ Note: This issue was marked complete via moderation. Points were issued even though the GitHub issue remains open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't workingfrontendIssues related to frontend development

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions