Skip to content

[test] Cover pool route authorization #2102

Closed

Description

@K1NGD4VID

Labels: testing, backend
File/location: backend/src/routes/poolRoutes.ts

Description:
Pool routes lack tests for lender ownership, admin-only actions, and paused pools.

Acceptance Criteria:

  • Add deterministic tests for the success, failure, boundary, and authorization paths described above.
  • Run the tests in CI and assert the documented public behavior and error contract.

Notes:
This focused regression gap was not covered by the existing test files reviewed in the sweep.

Activity

  1. added
    backendIssues related to backend development
    testingAdding or fixing tests
    on Oct 22, 2026
  2. ravimahatonp commented on Oct 22, 2026

    @ravimahatonp

    Hello team,

    I examined the issue "[test] Cover pool route authorization" in LabsCrypt/remitlend and would be glad to implement the required changes.

    I have reviewed the problem description and acceptance criteria for this issue. I have a clear, tested implementation ready with defensive error handling and 100% green CI proof.

    I will deliver a clean, well-tested, and production-ready PR promptly upon assignment. Kindly assign this issue to me.

    Thank you!

  3. maxx-GENIUS commented on Oct 22, 2026

    @maxx-GENIUS

    Hello @LabsCrypt,

    I'm interested in tackling this issue. Here is how I plan to resolve it:

    1. I will analyze the test harness, reproduce the failure/edge conditions deterministically, and implement comprehensive test coverage ensuring event schemas and invariants hold across all executions.
    2. Add full test coverage and ensure clean CI verification.

    Feel free to assign this to me and I will have the PR up today.

  4. thatslinx commented on Oct 22, 2026

    @thatslinx

    @thatslinx has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello maintainer i have reviewed this issue and i will love to work on it. Kindly assign me thank you.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @thatslinx to this issue.

  5. Emoji-dot commented on Oct 22, 2026

    @Emoji-dot

    @Emoji-dot has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I would like to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Emoji-dot to this issue.

  6. Starkid591 commented on Oct 22, 2026

    @Starkid591

    @Starkid591 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Please assign me this
    I would really appreciate if assigned me this

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Starkid591 to this issue.

  7. Favouratambi commented on Oct 22, 2026

    @Favouratambi

    @Favouratambi has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi! I've looked at the issue details and I love this kind of task. I'm confident I can handle it and deliver a well-tested PR on time. I'd be happy if you assign it to me

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Favouratambi to this issue.

  8. abdooltata commented on Oct 22, 2026

    @abdooltata

    @abdooltata has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Kindly assign me this issue lab.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @abdooltata to this issue.

  9. TeeGeason05 commented on Oct 22, 2026

    @TeeGeason05

    @TeeGeason05 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I'd like to work on this issue. I expect to complete it within the hour.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @TeeGeason05 to this issue.

  10. Horpeyehmi commented on Oct 22, 2026

    @Horpeyehmi

    @Horpeyehmi has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello, I would like to work on this issue. Kindly assign it to me.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Horpeyehmi to this issue.

  11. CryptoverseOG commented on Oct 22, 2026

    @CryptoverseOG

    @CryptoverseOG has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello Maintainer, I’ve reviewed the issue and understand the expected outcome. I’m interested in taking responsibility for this task and would appreciate your consideration for the assignment.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @CryptoverseOG to this issue.

  12. EmmyLee07 commented on Oct 22, 2026

    @EmmyLee07
    Contributor

    @EmmyLee07 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I would like to work on this

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @EmmyLee07 to this issue.

  13. drips-wave commented on Oct 22, 2026

    @drips-wave

    Congratulations, @EmmyLee07! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @EmmyLee07: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  14. added a commit that references this issue on Oct 29, 2026
  15. drips-wave commented on Oct 29, 2026

    @drips-wave

    This issue has been marked as completed by a Drips Wave moderator for @EmmyLee07 as part of the Stellar Wave Program's 10th Wave 🥳

    Moderator's reason: [Auto-assessed] PR #2209 was successfully merged by maintainers on 2026-10-29 (mergedAt: 2026-10-29T06:15:25Z), fulfilling Issue #2102. The PR adds comprehensive Jest/Supertest coverage for pool route authorization, lender wallet checks, and pause states with 100% diff coverage.

    😎 @EmmyLee07: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

    ℹ️ Note: This issue was marked complete via moderation. Points were issued even though the GitHub issue remains open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbackendIssues related to backend developmenttestingAdding or fixing tests

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions