Repository navigation
[Docs] Update the squad from Squad-Spec-Repository-Template - #383
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018g33ARQ6Pp6oXrdGfeuQAC
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request
📖 Description
Refreshes the squad from Squad-Spec-Repository-Template (profile
dotnet,b38a99f→cee6347). The managed files change as the template ships them:sonar-check.pyreports a non-main-branch Sonar read as NOT CHECKED with a pointer to the PR check (Template#188),squad-security.mdandorchestration.mdgain the A denied measurement rule (Template#207), plus smaller changes toplan-check.py,session-start.sh,AGENTS.md,.github/copilot-instructions.mdanddocs/CONTRIBUTING.md. The seeded.squad/stack.mdand.config/dotnet-tools.jsonare carried over by hand: the formatterreihitsu.cli1.1.0 (the Reihitsu.Analyzer release line) is now pinned in the tool manifest and run asdotnet tool run reihitsu-format. No file was skipped or removed. The two issues #374 and #375 that triggered this are closed with a pointer to the template issues.🎫 Issues
Related: #374, #375 (closed; fixed in the template).
💬 Reviewer Notes
The managed files were reviewed in their template PRs. Not changed here, on purpose:
.github/workflows/ci.ymlandrelease.ymlstill install the formatter withdotnet tool install -g Reihitsu.Cli, andREADME.md,docs/CONTRIBUTING.md(project block) anddocs/UNIT_TESTS.mdstill namereihitsu-formatdirectly; both keep working next to the manifest. Moving CI todotnet tool restoreis a CI workflow change and a follow-up. The template'sfork-scope.ymlis unchanged.📑 Test Plan
python3 .squad/tools/config-check.pypasses;dotnet tool restoreanddotnet tool run reihitsu-format --check ./report 0 files needing formatting. No production or test code changed.✅ Checklist
.squad/stack.md, and the Analyzer gate reports no diagnostic in a changed file. (format check only; no C# changed).squad/stack.mdpasses. (not applicable, no code change).squad/stack.mdprescribes. (none; the tool manifest gains the formatter already used)csharp.instructions.mdare followed. (no C# changed)