Skip to content

[Docs] Update the squad from Squad-Spec-Repository-Template - #383

Merged
LarsLaskowski merged 1 commit into
mainfrom
claude/stoic-johnson-1d6qbb
Oct 31, 2026
Merged

LarsLaskowski merged 1 commit into
mainfrom
claude/stoic-johnson-1d6qbb

Conversation

@LarsLaskowski

@LarsLaskowski LarsLaskowski commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

Pull Request

📖 Description

Refreshes the squad from Squad-Spec-Repository-Template (profile dotnet, b38a99f → cee6347). The managed files change as the template ships them: sonar-check.py reports a non-main-branch Sonar read as NOT CHECKED with a pointer to the PR check (Template#188), squad-security.md and orchestration.md gain the A denied measurement rule (Template#207), plus smaller changes to plan-check.py, session-start.sh, AGENTS.md, .github/copilot-instructions.md and docs/CONTRIBUTING.md. The seeded .squad/stack.md and .config/dotnet-tools.json are carried over by hand: the formatter reihitsu.cli 1.1.0 (the Reihitsu.Analyzer release line) is now pinned in the tool manifest and run as dotnet tool run reihitsu-format. No file was skipped or removed. The two issues #374 and #375 that triggered this are closed with a pointer to the template issues.

🎫 Issues

Related: #374, #375 (closed; fixed in the template).

💬 Reviewer Notes

The managed files were reviewed in their template PRs. Not changed here, on purpose: .github/workflows/ci.yml and release.yml still install the formatter with dotnet tool install -g Reihitsu.Cli, and README.md, docs/CONTRIBUTING.md (project block) and docs/UNIT_TESTS.md still name reihitsu-format directly; both keep working next to the manifest. Moving CI to dotnet tool restore is a CI workflow change and a follow-up. The template's fork-scope.yml is unchanged.

📑 Test Plan

python3 .squad/tools/config-check.py passes; dotnet tool restore and dotnet tool run reihitsu-format --check ./ report 0 files needing formatting. No production or test code changed.

✅ Checklist

  • I have added or updated Unit Tests for the change. (no production code)
  • I have tested my changes.
  • I have run Format and Build from .squad/stack.md, and the Analyzer gate reports no diagnostic in a changed file. (format check only; no C# changed)
  • The Coverage gate in .squad/stack.md passes. (not applicable, no code change)
  • I have updated the project documentation. (not applicable)
  • I have read the CONTRIBUTING documentation and followed the project's code style guidelines.
  • New dependencies, if any, were added the way Dependencies in .squad/stack.md prescribes. (none; the tool manifest gains the formatter already used)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018g33ARQ6Pp6oXrdGfeuQAC
@sonarqubecloud

Copy link
Copy Markdown

@LarsLaskowski
LarsLaskowski marked this pull request as ready for review October 31, 2026 16:30
@LarsLaskowski
LarsLaskowski merged commit bb924ba into main Oct 31, 2026
6 checks passed
@LarsLaskowski
LarsLaskowski deleted the claude/stoic-johnson-1d6qbb branch October 31, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants