Repository navigation
[Tests] Add regression tests for scan batch isolation and finding preservation - #386
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018g33AVkNQL3d9dKGezxS93
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018g33AVkNQL3d9dKGezxS93
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request
📖 Description
F-024 (a failing item aborting the scan batch) and F-025 (active findings lost on a transient feed error) are already fixed on
main, but two paths still had no regression test. This change adds three tests: a two-image and a two-instance batch where the first item fails before its innertryand the other item must still be scanned to completion, and an observed image whose derived .NET finding must stay active when the release feed fails. TheSaveChangesFailingDbContexttest double gets aFailOnSaveAttemptoption that fails exactly one save attempt. No production code changes; each test was shown to fail when its guard is removed.🎫 Issues
Closes #19
💬 Reviewer Notes
Tests only. The batch order of the scan is not fixed, so the tests assert on "the item that failed" and "the other one", never on which comes first. While writing them, two related defects surfaced and were filed separately: #384 and #385.
📑 Test Plan
Three new tests in
ImageScanOrchestratorTestsandRuntimeContainerScanOrchestratorTests. Full suite passes (1008 + 21), overall line coverage 88.3 %.✅ Checklist
.squad/stack.md, and the Analyzer gate reports no diagnostic in a changed file..squad/stack.mdpasses (line coverage on new or changed production code and overall).README.md,ARCHITECTURE.md) to reflect my changes..squad/stack.mdprescribes.csharp.instructions.mdare followed.⏭ Next Steps