area request fixes - #15
Open
fayeforpay wants to merge 1 commit into
Open
fayeforpay wants to merge 1 commit into
fayeforpay wants to merge 1 commit into
Conversation
fix both p48 & block - zone update crashes add region request answers
LastExceed
reviewed
Sep 17, 2026
| state: State::Ready, | ||
| progress_current: 0, | ||
| progress_maximum: 0, | ||
| zone: Point2::origin() |
Owner
There was a problem hiding this comment.
is zone an offset relative to the sector? if not, would it make sense to compute this value properly?
| unknown_a: 0, | ||
| unknown_b: 0, | ||
| unknown_c: 0, | ||
| id: 0, |
Owner
There was a problem hiding this comment.
shouldn't each mission have a different id ?
Comment on lines
+24
to
+25
| let zone_loot = self.loot.read().await.get(&zone).cloned().unwrap_or_default(); | ||
| source.send_ignoring(&WorldUpdate::from((zone, zone_loot))).await; |
Owner
There was a problem hiding this comment.
Doesn't this effectively render the addon_data.zone_requests checks redundant, as it always satisfies the client on the first request?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
most basic version of the fix I could come up with until I have a better understanding of how Cube World handles zones, in hopes to write a more sophisticated fix in the future.