fix(validate): stop the false positives, name the right edge, warn once - #449
Merged
Merged
Conversation
Five items from #437. An arrow or connector paid arrowhead padding on all four sides whether or not a head was drawn, so a headless arrow 30px from an edge was reported as overflowing. The padding is now conditional on arrow_start || arrow_end. The same function ignored a curve's implicit control point, so a bulging arrow could leave the frame and validate clean; the control point is folded into the bounding box, which is a conservative bound because a quadratic stays inside the hull of its three points. The overflow hint always said "current right edge" on the X axis and "current bottom edge" on Y. A left-edge overflow at x=-102 was therefore reported against a right edge that was never measured. It names the edge that actually overflowed now. gradient_text's stop position accepts offset as an alias. The two vocabularies had no semantic difference to justify two names, and aliasing keeps every existing scenario working where renaming would not. schema.rs's alias table gains the entry, without which the exported schema would declare offset invalid while the parser honours it -- exactly the class #162 closed. The "overlap longer than transition" warning printed twice at validate and three times at render. There was only ever one eprintln!, in v2_build_composited, reached by however many callers happened to build frame tasks. Detection moves into a pure function called once from check_off_grid_cuts, and the diagnostic leaves the planning function that had no business emitting it. validate printed durations to one decimal, so 2.95s read as "3.0s" -- exactly the figure someone sizing a voice-over would trust. Three decimals, matching migrate, sheet and tasks. Closes #437
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #437. Part of #438.
Arrow and connector bounds. The geometry pass paid arrowhead padding on all
four sides whether or not a head was drawn, so a headless arrow 30 px from an edge
was reported as overflowing. The padding is conditional on
arrow_start || arrow_endnow. The same function ignored a curve's implicitcontrol point, so a bulging arrow could leave the frame and validate clean — the
control point is folded into the bounding box, a conservative bound because a
quadratic stays inside the hull of its three points.
The overflow hint named an edge it never measured. It always said "current
right edge" on X and "current bottom edge" on Y, so a left-edge overflow at
x = -102was reported against a right edge. It names the edge that actuallyoverflowed.
Gradient stop vocabulary.
gradient_text's stoppositionacceptsoffsetas an alias. The two spellings had no semantic difference to justify two names,
and aliasing keeps every existing scenario working where renaming would not.
That has a hard dependency the workstream flagged and could not satisfy itself:
schema.rs's alias table needs the matching entry, or the exported schemadeclares
offsetinvalid while the parser honours it — exactly the class #162closed. Added.
The duplicated warning. "Overlap longer than transition" printed twice at
validate and three times at render. There was only ever one
eprintln!, inv2_build_composited, reached by however many callers happened to build frametasks that run. Detection moves into a pure function called once from
check_off_grid_cuts, and the diagnostic leaves a planning function that had nobusiness emitting it.
Durations.
validateprinted one decimal, so 2.95 s read as "3.0s" — exactlythe figure someone sizing a voice-over would trust. Three decimals, matching
migrate,sheetandtasks.A gap this turned up in #446's own test
The workstream predicted its alias would break
every_serde_alias_in_the_sources_is_reachable_from_the_exported_schema. It didnot — and the reason is a weakness in that test, not good luck: it checks the
alias string appears anywhere in the schema, and
"offset"was already there asa background stop's own field name.
Two tighter tests replace the assumption.
every_entry_in_the_two_tables_actually_lands_in_the_exported_schemaimmediatelyfound two inert entries I shipped in #446:
("Component", …)and("ChildComponent", …)name definitions that no longer carry the enum, becausewrap_with_directivesrenames them toComponentBase/ChildComponentBasebeforethe aliases are applied. The aliases were landing through the
…Baseentriesalone. The dead rows are removed.
Docs
text-component-parity.mdandSKILL.mdsaid, as of #446 an hour ago, that thevalidator refuses
offseton agradient_textstop. That is now false, and bothare corrected in this PR rather than left to contradict the code.
Tests
Nine, each reverted and watched go red:
Not in scope
info.rscarries the same{:.1}sdisplay and the deeper duration-accountingbugs of #372 items 1 and 2. #437 names the
validatedisplay only.