Repository navigation
⚡ Bolt: Optimize LanguageDetector regex split overhead - #729
LeanBitLab wants to merge 1 commit into
Conversation
Eliminated `Regex.split` and intermediate `.filter` list allocations in `LanguageDetector.detectByHeuristics`. Replaced with manual character iteration (`char.isLetter()`) and a `StringBuilder` to process words inline.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Merged into main via commit 21622d7. |
💡 What: Replaced
text.lowercase().split(NON_LETTER_REGEX).filter { it.length >= 2 }inLanguageDetector.detectByHeuristicswith a manual character iteration loop using aStringBuilder.🎯 Why: Calling
.split(Regex)and chained.filtercreated unnecessary intermediate list allocations and involved regex engine execution overhead during text classification and proofreading hot paths, causing unnecessary GC pressure.📊 Expected Impact: Reduced GC pressure and faster execution in text processing hot paths by avoiding regex compilation/execution and eliminating intermediate object allocations.
🔬 Verification: Verified locally via
./gradlew :app:assembleStandardDebugand./gradlew :app:testStandardDebugUnitTest. Tests completed successfully.PR created automatically by Jules for task 5320803216098800702 started by @LeanBitLab