You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
isInExtendedSupport silently accepts zero LifecycleSupportStartDate #1315
After PR #1234, isInExtendedSupport (cmd/multi_service_engine_versions.go:399-416) treats a zero LifecycleSupportEndDate as "open-ended" (intentional, for engines whose end-of-extended-support has not yet been published). But it also treats a zero LifecycleSupportStartDate permissively — now.Before(time.Time{}) is false, so the start gate is skipped. Combined, an extended-support lifecycle entry with both dates absent in the AWS response will be classified as currently in extended support, with no log line surfacing that the data was anomalous.
In practice this is unlikely (the RDS API normally returns both dates when it returns the lifecycle name), but if it does occur:
false-positive: instance is dropped from the recommendation count even though we have no evidence the support window is currently active,
silent — the responsible code path has no logging when the input is suspicious.
Per feedback_no_silent_fallbacks.md, an anomalous SDK payload on a money-relevant path should fail loud (or at minimum log + metric) rather than be coerced to a default.
Suggested fix
In isInExtendedSupport, when LifecycleSupportName == OpenSourceRdsExtendedSupport AND LifecycleSupportStartDate.IsZero():
emit a structured warn log identifying the engine/version,
skip the entry (treat as "unknown lifecycle window") rather than implicitly accepting it.
Optional: also surface the count via a metric so missing-date payloads are observable.
Activity
IAmJSD commentedon Oct 16, 2026
Claiming: working on this