Closed
Labels
effort/xsTrivial / one-linerTrivial / one-linerimpact/manyAffects most usersAffects most userspriority/p2Backlog-worthyBacklog-worthyseverity/mediumModerate harmModerate harmtriagedItem has been triagedItem has been triagedtype/choreMaintenance / non-user-visibleMaintenance / non-user-visibleurgency/this-quarterWithin the quarterWithin the quarter
Description
Context
#714 (merged as 81a7090) makes pkg/recfilter dedupe each term and payment variant against the full held quantity (#703). Providers only pick it up when their pkg pin moves to that merge. Until then the over-buy (one held unit reducing only the first variant) still happens through the provider modules.
That PR also removed TestHeldReservation_VariantPin from providers/azure/services/managedredis/held_reservation_dedupe_test.go. It asserted the old 1, 2, 2, 2 behaviour, and CI runs the provider modules both through go.work (new pkg) and with GOWORK=off (pinned pkg), so no single assertion could pass both.
Work
- Re-pin
providers/azureandproviders/awsto the fix(recfilter): dedupe each term and payment variant against the full held quantity #714 merge (first commit, mechanical:go getplusgo mod tidyunderGOWORK=off). - Restore the managedredis variant test asserting 1, 1, 1, 1.
- Check the other provider tests that exercise recfilter variants (Azure compute, savings plans, reservations, AWS recommendations) still pass under
GOWORK=off. - CHANGELOG: nothing new beyond fix(recfilter): dedupe each term and payment variant against the full held quantity #714's entry unless a provider test changes behaviour.
Order
After any other provider PR that bumps pkg, to avoid re-pin conflicts.
Metadata
Metadata
Assignees
Labels
effort/xsTrivial / one-linerTrivial / one-linerimpact/manyAffects most usersAffects most userspriority/p2Backlog-worthyBacklog-worthyseverity/mediumModerate harmModerate harmtriagedItem has been triagedItem has been triagedtype/choreMaintenance / non-user-visibleMaintenance / non-user-visibleurgency/this-quarterWithin the quarterWithin the quarter
Activity
cristim commentedon Nov 9, 2026
Claimed by claude-qa-ui-4: re-pin providers/azure and providers/aws past #714, restore the managedredis variant test, and check the other recfilter-variant tests under GOWORK=off. I will rebase the pin onto whichever provider PR (#712, #713) merges first, as the Order section asks.