Skip to content

RI Marketplace: status poller (active->closed + proceeds/fee) + seller-account precondition UI (closes #292 remainder) #27

Closed

Description

@cristim

Context

PR LeanerCloud/cloud-commitments-cli#808 (closes LeanerCloud/cloud-commitments-cli#292) implements the AWS RI Marketplace list and cancel flows for Standard RIs. To keep that PR landable, two parts of LeanerCloud/cloud-commitments-cli#292 were intentionally descoped:

  1. Status poller that transitions a listing active -> closed once it sells, and records realized proceeds and the AWS transaction fee actually charged.
  2. Seller-account precondition UI that checks the AWS seller account is registered (US bank account on file) and surfaces a tailored message before the user attempts to list.

Because the poller is unimplemented, migration 000060 in PR LeanerCloud/cloud-commitments-cli#808 was reduced to only the three columns the implemented flow reads/writes (offering_class, listing_id, listing_state). The settlement/poller columns (listed_at, listing_price_schedule, listing_proceeds_received, listing_fee_paid) were removed so the schema never carries columns nothing populates. They should be re-added alongside the poller in this follow-up.

Scope

Out of scope

Listing creation and cancellation (already shipped in LeanerCloud/cloud-commitments-cli#808).

Activity

  1. 14 remaining items

  2. IAmJSD commented on Oct 23, 2026

    @IAmJSD
    Collaborator

    Claiming: working on this

  3. self-assigned this
    on Oct 23, 2026
  4. IAmJSD commented on Oct 28, 2026

    @IAmJSD
    Collaborator

    Status update (2026-10-28): #1559 merged: AWS SellerNotRegistered now returns a 400 with a fixed explanation and reason: seller_not_registered.

    Left: exposing proceeds (owner decision D23), superseded listings (D24, see #1494), and the Sell-dialog precondition message and Sold/proceeds display (UI owner).

  5. cristim commented on Nov 11, 2026

    @cristim
    MemberAuthor

    Claimed by claude-platform-2.

  6. cristim commented on Nov 11, 2026

    @cristim
    MemberAuthor

    Releasing my claim (claude-platform-2): per the last status comment what remains depends on owner decisions D23 (exposing proceeds) and D24 (superseded listings, #1494), plus the proceeds-display work held in #1586. Not starting without those.

  7. cristim commented on Nov 12, 2026

    @cristim
    MemberAuthor

    Checked on origin/main 447a98b. Partly met, leaving open.
    Met:

  8. cristim commented on Nov 14, 2026

    @cristim
    MemberAuthor

    Claimed by claude-platform (widened goal, 2026-11-14). Working this in a worktree; will post the landed commit or a blocker here.

  9. cristim commented on Nov 14, 2026

    @cristim
    MemberAuthor

    Decision (claude-platform, 2026-11-14): blocked, claim released, no code landed. Both remaining parts need API changes: (a) a seller-registration status endpoint, because the only SellerNotRegistered signal is the 400 after a failed list attempt (internal/api/handler_marketplace.go ~442-488); (b) realized proceeds and fee fields on history or listing responses (GetMarketplaceListingProceedsTotals exists only in internal/config and the poller). Owner input: approve the two API additions and their response shapes, then this can be picked up.

  10. cristim commented on Nov 14, 2026

    @cristim
    MemberAuthor

    Claimed by claude-platform-2.

  11. cristim commented on Nov 14, 2026

    @cristim
    MemberAuthor

    Checked on origin/main (claude-platform-2). Shipped: the status poller (internal/api/handler_marketplace_poller.go, scheduler hook in internal/server/handler_marketplace_poll.go) with active to closed/canceled transitions, realized proceeds and fee persisted (migrations 000144, 000153, store_postgres_marketplace_settlement.go), the tailored SellerNotRegistered 400, and superseded-listing handling (#1494). Two items remain and are both gated, so they do not need this issue: exposing proceeds/fee in the API and UI waits on the real-listing check, estimate labels and totals scoping tracked in #1586 (owner-only); a seller-registration precondition endpoint needs an owner-approved response shape and a real seller call (AWS has no lookup). Closing as completed; reopen or file from #1586 when those gates clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions