test: skip timing benchmarks in CI - #18
Merged
Merged
Conversation
The threading/asyncio/datatype performance tests measure wall-clock speedups, which shared CI runners can't deliver reliably: the large-data threading test failed at 0.88x on macos-15-intel and 0.68x on windows-latest with no code change. Mark every timing test `perf` and deselect them in all CI pytest runs (-m "not perf"). The correctness tests in those files (GIL release output quality, release_gil parameter) keep running. Locally, plain `pytest` still runs everything. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The performance tests measure wall-clock speedups, and shared CI runners can't deliver those reliably.
test_conditional_gil_release_large_data_threadingfailed with no code change at 0.88× on macos-15-intel (#15) and at 0.68× on windows-latest (#17).test_threading_performance.py, all oftest_asyncio_performance.pyandtest_datatype_performance.py) are markedperf. Every CI pytest run deselects them with-m "not perf": the cibuildwheel test command, the sdist job, the oldest-NumPy job and the NumPy-nightly job.test_gil_release_quality,test_release_gil_parameterandtest_release_gil_parameter_invalid.pyteststill runs everything;pytest -m perfruns just the benchmarks.CI now runs 138 tests (68 deselected) instead of 206, which also saves roughly 20–60 s per wheel across 20 wheels.
🤖 Generated with Claude Code