Harden GitHub release workflow - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The repository has no published releases. The existing tag release job ran without repository context, so
gh releasecould not reliably create the draft. The release workflow also depended on an unverified long-lived secret and did not guard against malformed versions, reused tags, or overwriting published assets.Validation
actionlint v1.7.12 .github/workflows/create_release.yml .github/workflows/build.yml0.14 -> 0.15passes; malformed, non-increasing, and reused-tag cases failgit diff --checkAfter merge
Run Actions > Create Release from
mainwith an unused version such as0.15. The workflow creates the version commit and tag, dispatches the tagged Windows build, and creates a Draft Release containing Setup, Portable, source, and checksum assets. Review the draft and applicable signing/GPL/security gates before publishing it.