Repository navigation
ci(benchmark): surface head-build failures instead of hiding make output - #246
Merged
Merged
Conversation
The head-build step sent make's output to /dev/null, which made the #244 red run undebuggable. Print the build-log tail on failure. Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
Per-op benchmark — p50 cycles (base vs head)base runs: 5, head runs: 5 (median of mins) · freq-correction ×0.9972 · threshold head−base > max(40 cyc, 5%)
* head frequency-corrected to base via the Regressions detected. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #245 (held back because pushing workflow files needs the
workflowtoken scope — now granted). On head-build failure, print the tail of the build log instead of sendingmakeoutput to /dev/null — that suppression is why the #244 red run was undebuggable. No behavior change on success.🤖 Generated with Claude Code