Add cxjs_nullif() - #131
Open
Lightning11wins wants to merge 1 commit into
Open
Conversation
Greptile SummaryThis PR adds client-side support for
Confidence Score: 4/5The null second-operand path needs a fix before merging.
centrallix-os/sys/js/ht_render.js
|
| Filename | Overview |
|---|---|
| centrallix-os/sys/js/ht_render.js | Adds cxjs_nullif(), but a null second operand incorrectly nullifies a non-null first operand. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
centrallix-os/sys/js/ht_render.js:324-325
**Null Second Operand Drops Value**
When `a` is non-null and `b` is null, this branch returns null instead of `a`. For example, `cxjs_nullif('value', null)` produces null, so client expressions can disagree with the server-side `NULLIF` result.
```suggestion
if (a == null || a == b) return null;
return a;
```
Reviews (1): Last reviewed commit: "Add cxjs_nullif()." | Re-trigger Greptile
Contributor
Author
|
This PR is cleared for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add the
cxjs_nullif()on the client, which runs with the same logic as the server-side version.