fix: resolve Clippy and README CI failures - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #62 fixes the Clippy errors, but its test workflow then fails because cargo-rdme requires a nightly Rust toolchain that CI does not install. Once that toolchain is installed, the README also fails the freshness check because its dependency links need regeneration.
This PR includes the original Clippy fixes from #62, pins cargo-rdme to 2.2.3 with locked dependencies, installs its required toolchain before checking the README, and regenerates the three
ark_ff::PrimeFieldlinks. The README freshness check remains enabled.Validated locally with Rust 1.98.0:
cargo check --workspace --all-targetscargo test --workspace(30 integration tests and 5 doc tests passed)cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo rdme --checkusing cargo-rdme 2.2.3 and its required nightly toolchain