Repository navigation
Phase 9: modeling upgrades - #69
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…instead Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…es and tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…son, zeros note in the read-only view, partial-save report Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
… code script Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…rid from the legend's matrix Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…n clamped, gating and key tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…registers, review minors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…re record, run on the CPU instead Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
… worker rows only, CPU hardware test, 404 on a vanished job, batch note Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…sortable trials Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
… per run, structured 409, expandable drop list, scoped invalidation Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…se alarm rate, error types Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…easons, V1 copy period, formula-guard test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
optuna==4.9.0 (journal storage, JournalFileOpenLock and fANOVA imports verified in
the testrunner). Setting.tune holds each model's default range; tuning/space.py
builds the default space (respecting `when`; a booster chain tunes its trees),
checks a user-sent space, fixes LightGBM's bagging and early-stopping trees, and
maps a space (mixed choices, Range.none) to Optuna suggestions and back.
POST /exports/{id}/batches kind "tune" checks the base run, metric, device
ceilings (TUNE_MAX_TRIALS, TUNE_MAX_TRIALS_GPU, TUNE_MAX_HOURS_GPU) and space,
then inserts the batch and its one run.tune job; batch-plan gains tune limits;
the feeder ignores tune batches. Pruning is off for CV, chains and models other
than LightGBM/XGBoost. run.tune is registered with its describe; its handler is
B8's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…PI names them by an unordered method set) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
… one stop path, refit as a run Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…stranded study blocks nothing, stop checks in every trial, time budget counts interrupted trials Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…; drops-only self-finalize
bulk_apply extracted from the bulk decisions route; POST /runs/{id}/derive-baseline (immediate, pending, dry run);
derive.after_finalize hooked into finalize; a derived version's creator finalizes it while it is drops-only
(audited as baseline.self_finalize); team state gains `derived`; lineage gains baseline nodes and the run edges.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…finalize_now re-checks the creator's role; review minors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…e of re-run drafts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…r leaves a run or study stuck; study only from its refit; more tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
Every parked B1-B10 finding and the suite triage: stale tests fixed (043 replay, RF encodes its categoricals, golden pins phase-0 categorical decisions), killed trials count their time (tuning_trials.last_seen), a cancel past the deadline is a stop, chain steps count members, logistic default space by target kind, target null rule for number labels, NUL refused in field texts, adjust_denied on experiments, one kind of pending.id, _start_study holds nothing while it starts the study, explicit /api/auth/check operation ids, openapi.json regenerated, docs for every new route and field, a tuning study in smoke.sh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…guide Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…r, server-side Run again, study failures
- I1: derive-baseline and rerun 404 a run whose experiment the caller can't see.
- I2: TuneDialog always sends order unless one-vs-rest.
- I3: POST /batches/{id}/again rebuilds the study from its stored spec (derive.study_request);
TuneSpec/StudyDetail types; fixture uses the real spec shape.
- I4: failed studies show their error; then_run.error shown on the export row.
- Minors 1-7, 10, 11 and the no-op half of 8.
- CI: API tests timeout 20 -> 45 minutes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 9 of the v2 roadmap, from the owner's review: modeling upgrades.
What it adds
Native categoricals for tree models. This is the default for every categorical in tree baselines; linear and neural models keep their encodings. They run end to end through export, training, scoring, the serving bundle, the registry equality check and the code script. Random forest refuses them with a clear message, and "Encode these fields" switches them to ordinal for one experiment.
One rule for missing values. Text such as "None", "NA" or "?" counts as missing only when the column never held it as a real value. This fixes a train/serve skew from before this phase, which made Diabetes readmission models impossible to register.
GPU/CPU switch on Train, batches and tuning. GPU runs reserve a GPU slot. A queued GPU job says it is waiting, and "Run on the CPU instead" is available to its starter, project owners and admins. Run facts show the hardware a run used.
Optuna tuning:
Metrics:
The UI and the backend share one fixture of confusion cases.
Field description and notes. These are edited on the field page by reviewers and above, and shown in the sidebar, tables and history. Baseline exchange format
rainforest-baseline/2carries them; import fills only empty ones, and the dry run previews the fill.A new baseline version from a run's drops. It comes with a dry run and pending derivations. Whoever applied a drops-only derivation can finalize it, rechecked against their current role; anything else is owner-only. From there you can re-run the experiment as it was, customise it first, or re-run its study. A re-run draft rebases automatically when its version finalizes.
Migration 043, with RLS on every new table, and a route-matrix row for every new route.
How it was built
The spec and plan were reviewed by Fable. There are 20 tasks, each reviewed separately: security-heavy tasks by Opus, the rest by Sonnet. Fix rounds were re-reviewed. Two privilege bugs were found and fixed with tests: a self-finalize from an unlocked read, and a demoted creator still finalizing. So was a regression that silently reverted one of those fixes.
Tests
🤖 Generated with Claude Code
https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS