Repository navigation
Test pass: every suite green after phases 9b–12 - #72
Merged
Merged
Conversation
…ings sections, pick mode no longer the default), MLFLOW_LOGGING in Compose, config.py's settings read allowed - The 9b final review (M9) chose "first in its team" on purpose; the unit, e2e and user-guide copy follow it. - Settings › Application is admin-only since phase 10; the member section list drops it. - helm: pick mode's case sets auth.mode=pick and devPick; a new case pins the password default. - CI stack job and smoke.sh seed mode: the stack specs sign in by picking, so the stack runs pick with the dev flag. - docker-compose.yml passes MLFLOW_LOGGING (test_config_wiring). - test_access_lint: config.py reads meta.app_settings with its own connection (db.py's pool is built from get_settings(), which calls it), listed in DRIVER_HOMES with that reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…, one-time links, must-change, pick needs the dev flag) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…e 10 and 9b D1 Stale tests (the code changed on purpose): - test_auth: pick mode needs RAINFOREST_DEV_PICK; the in-memory store stubs the sign-in audit and credentials; /me's new password fields; the pick is audited. - test_oidc: /api/auth/config names which sign-ins are on (password, oidc). - test_mlflow: emails are unique since 046, so the trainer Ana is made once. - test_gpu_waiting: a study's ends_by is policy.study_max_exec_s (its hours plus the last trial's margin). - test_gpu_supervise: a cluster blip on create requeues without burning a try (counts=False). - test_rls_app: the replay tripwire moves to 046 (045 and 046 replay cleanly). - test_route_matrix: the vault table keeps a route's own gate (reset-link is a 404 in pick mode). New: - test_app_settings: an override applies at once and a reset drops the row; a Lab choice above NOTEBOOK_CPU_LIMIT/NOTEBOOK_MEMORY_LIMIT is refused with nothing saved; every change is audited; bad values and members refused. - 9b D1: WaitingForQuota is in line (dispatch and kube.workload_state), the redaction filter keeps an untouched record's args (uvicorn's AccessFormatter), the sweep leaves a Job's own pod. Each fails with its fix reverted. - FakeKueue: a Job's pod carries the template's GPU and job-id labels and an ownerReferences to its Job, and objects() reports owner_kind as the real client does (the baa26aa class of bug); wait_for_quota(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…b fixes) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
…s as an upgrade would Run serially on one database, two replays broke later files: 031-033's replayed 041 (which drops every policy) and then only 042-044, so 045 and 046's tables lost theirs (test_passwords, test_every_meta_table_has_rls); and 010's replay put back its permissive SELECT policies, which 041 drops on an upgrade. Every migration from 041 on follows now, and 010's policies are dropped after its replay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
Owner
Author
|
Serial API run on a fresh database (after 751972e, which fixed two migration replays that only broke a shared, serial database): 3019 passed, 0 failed, 0 skipped. Client tests: 79 passed. MLflow sidecar: 3 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test pass after phases 9b–12, which merged without running their tests on purpose. Every suite is green.
Stale tests (the code changed on purpose)
auth.mode=pickandauth.devPick, and a new case pins the password default.RAINFOREST_AUTH_MODE=pickandRAINFOREST_DEV_PICK=true, because the stack specs sign in by picking a user.smoke.shseed mode documents that it needs a pick stack. Its chart path already usesci/dev-values.yaml.test_authsets the dev flag and stubs the sign-in audit and the credentials lookup. It also covers/me's new fields.MLFLOW_LOGGINGis now passed throughdocker-compose.ymland listed in.env.example.config.pyreadsmeta.app_settingswith its own connection. db.py's pool is built fromget_settings(), which calls this read, so going through db.py would recurse. It is now inDRIVER_HOMES, with that reason.ends_byincludes the last-trial margin.New tests
test_app_settings.py):test_passwords.py, 36 tests):CLIENT_IP_HOPS, and the lock persisted before the refusal.RAINFOREST_DEV_PICK.ownerReferencesentry, andobjects()reportsowner_kindas the real client does. This catches the baa26aa class of bug.Counts (local)
make test-full: 3019 passed.nginx/test.shpasses.No product code changed: no test showed a real bug.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS